Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for JS #715

Merged
merged 17 commits into from
Feb 1, 2024
Merged

feat: Add support for JS #715

merged 17 commits into from
Feb 1, 2024

Conversation

huntabyte
Copy link
Owner

@huntabyte huntabyte commented Jan 30, 2024

This PR adds support for JavaScript.

Users can select whether they are using TypeScript or not via the init CLI prompt and the appropriate components/filenames/etc. will be added to their project when adding components.

This is accomplished by preprocessing the Svelte components and compiling the TS files into separate registry directories that are used for JS projects.

Before submitting the PR, please make sure you do the following

  • If your PR isn't addressing a small fix (like a typo), it references an issue where it is discussed ahead of time and assigned to you. In many cases, features are absent for a reason.
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Follows the contribution guidelines.
  • Format & lint the code with pnpm format and pnpm lint

Copy link

changeset-bot bot commented Jan 30, 2024

🦋 Changeset detected

Latest commit: 256f11e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
shadcn-svelte Minor
playground-js Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
shadcn-svelte ⬜️ Ignored (Inspect) Visit Preview Feb 1, 2024 1:07am

@huntabyte huntabyte merged commit bfdc861 into main Feb 1, 2024
5 checks passed
@huntabyte huntabyte deleted the playground branch February 1, 2024 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants