Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow for default select icon to be hidden #817

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MentalGear
Copy link
Contributor

I'd like to propose adding an option to switch off the default select icon in the Select Input.
This would allow using custom icons with ease by providing them right in the slot, or none at all if the dev prefers.

Example:
Screenshot 2024-02-25 at 11 23 13

Before submitting the PR, please make sure you do the following

  • If your PR isn't addressing a small fix (like a typo), it references an issue where it is discussed ahead of time and assigned to you. In many cases, features are absent for a reason.
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Format & lint the code with pnpm format and pnpm lint

Hides default select icon and makes padding adjustment
Copy link

changeset-bot bot commented Feb 25, 2024

⚠️ No Changeset found

Latest commit: 882be57

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Feb 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
shadcn-svelte ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 25, 2024 10:56am

@MentalGear
Copy link
Contributor Author

Just noticed that the element received an update before my code adjustment - let me know if you agree with the general idea and we can see to update it to the new version. Cheers !

@huntabyte
Copy link
Owner

Hey there, I'm cool with adding this prop.

Let's make the prop withIndicator defaulting to true. These changes should apply to both the new-york and default styles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants