Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve Calendar styling on Mail example #826

Merged
merged 1 commit into from
Feb 26, 2024
Merged

docs: improve Calendar styling on Mail example #826

merged 1 commit into from
Feb 26, 2024

Conversation

shyakadavis
Copy link
Contributor

@shyakadavis shyakadavis commented Feb 26, 2024

Before submitting the PR, please make sure you do the following

Minor styling issue; previously set the padding on the Calendar itself - terrible idea.

Before:

Screenshot 2024-02-26 at 19 17 28

After:

Screenshot 2024-02-26 at 19 17 37

P.S. I don't know why the registry files are being affected - just did pnpm dev and they "built". 🤷‍♂️

  • If your PR isn't addressing a small fix (like a typo), it references an issue where it is discussed ahead of time and assigned to you. In many cases, features are absent for a reason.
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Format & lint the code with pnpm format and pnpm lint

Copy link

changeset-bot bot commented Feb 26, 2024

⚠️ No Changeset found

Latest commit: 23dd26d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Feb 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
shadcn-svelte ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 26, 2024 5:23pm

@shyakadavis shyakadavis changed the title docs: improve Calendar styling docs: improve Calendar styling on Mail example Feb 26, 2024
@huntabyte
Copy link
Owner

Don't worry about the registry bit, we probably should add them to the .gitignore since they are built when the app is deployed anyways!

Copy link
Owner

@huntabyte huntabyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@huntabyte huntabyte merged commit 9ed8f32 into huntabyte:main Feb 26, 2024
5 checks passed
@shyakadavis shyakadavis deleted the docs/improve-calendar-styles branch February 26, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants