Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Edit import of "$lib/utils" in new component "ScrollArea" for consistency across the repo #869

Closed
wants to merge 2 commits into from

Conversation

ekpah
Copy link

@ekpah ekpah commented Mar 7, 2024

Make a small edit in the import of a new component to stay consistent and prevent potential conflicts, if only "utils.ts" and not "utils.js" exists

ekpah added 2 commits March 7, 2024 11:24
change utils.js to utils in Scroll-Area-Scrollbar
Copy link

changeset-bot bot commented Mar 7, 2024

⚠️ No Changeset found

Latest commit: 8079891

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 7, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
shadcn-svelte ✅ Ready (View Log) Visit Preview 8079891

Copy link
Owner

@huntabyte huntabyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually an issue we need to address with the transformation. It should be $lib/utils.js across the entire project to support both bundlers and Node.

@huntabyte
Copy link
Owner

The extension of the import should be what it is compiled to, which is utils.js not utils.ts. See https://www.typescriptlang.org/docs/handbook/modules/theory.html#module-resolution-for-libraries

@huntabyte huntabyte closed this Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants