Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: investigate increased build times #891

Closed
wants to merge 1 commit into from

Conversation

AdrianGonz97
Copy link
Collaborator

@AdrianGonz97 AdrianGonz97 commented Mar 11, 2024

As of #850, our build times have increased by a considerably large amount, going from just under 2 mins, to almost 8 mins. There are a number of changes in #850, most notably the transition to SK 2 and Vite 5, but @sveltejs/enhanced-img was added as well (which certainly contributes to the time increase, and may be a the biggest contributor).

This PR aims to figure out the main culprit. This is not intended to be merged, so it'll stay as a draft.

EDIT: Removing @sveltejs/enhanced-img resulted in build times going back to how they used to be, possibly even faster.

Before submitting the PR, please make sure you do the following

  • If your PR isn't addressing a small fix (like a typo), it references an issue where it is discussed ahead of time and assigned to you. In many cases, features are absent for a reason.
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Format & lint the code with pnpm format and pnpm lint

Copy link

changeset-bot bot commented Mar 11, 2024

⚠️ No Changeset found

Latest commit: 508b16b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 11, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
shadcn-svelte ✅ Ready (View Log) Visit Preview 508b16b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant