Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update lucide-svelte & icon names #898

Merged
merged 1 commit into from
Mar 13, 2024
Merged

chore: update lucide-svelte & icon names #898

merged 1 commit into from
Mar 13, 2024

Conversation

shyakadavis
Copy link
Contributor

@shyakadavis shyakadavis commented Mar 13, 2024

Notes

Closes: #897

  • Updates the icon package (lucide-svelte) and renames the icons to the new names.
  • I didn't build the registry because you mentioned some time back that the registry is built regardless on each app build/deployment, right? @huntabyte
  • Forgive the auto imports sorting/organization. I forgot to disable this rule in my IDE. Hope you don't mind.
// Auto sort/move imports on save
	"editor.codeActionsOnSave": {
		"source.organizeImports": "always"
	}

Before submitting the PR, please make sure you do the following

  • If your PR isn't addressing a small fix (like a typo), it references an issue where it is discussed ahead of time and assigned to you. In many cases, features are absent for a reason.
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Format & lint the code with pnpm format and pnpm lint

Copy link

changeset-bot bot commented Mar 13, 2024

⚠️ No Changeset found

Latest commit: c2b5fdc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 13, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
shadcn-svelte ✅ Ready (View Log) Visit Preview c2b5fdc

Copy link
Owner

@huntabyte huntabyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shyakadavis, you rock!

@huntabyte huntabyte merged commit ed4592c into huntabyte:main Mar 13, 2024
4 checks passed
@shyakadavis shyakadavis deleted the fix/incorrect-icon-import branch March 13, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

import Pagination/Breadcrumb fails
2 participants