Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): Fix update script end log incorrectly displaying, fix init script utils file creation #915

Merged
merged 3 commits into from
Mar 16, 2024

Conversation

WarningImHack3r
Copy link
Contributor

Before submitting the PR, please make sure you do the following

  • If your PR isn't addressing a small fix (like a typo), it references an issue where it is discussed ahead of time and assigned to you. In many cases, features are absent for a reason.
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Format & lint the code with pnpm format and pnpm lint

Fixes #914, which fixes #844.

Fix incorrect falsy value when checking if there are components to remove at the end of the update process.

Also, fix the init script, which incorrectly creates a utils.js.ts file. The file extension is already added upon creation, so we don't need this. We might however need the file extension within the config file or a better alias resolution mechanism, so maybe I should move that out of this PR? Or maybe it's a good first fix for the file creation?

Copy link

changeset-bot bot commented Mar 16, 2024

🦋 Changeset detected

Latest commit: 053163e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
shadcn-svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@AdrianGonz97
Copy link
Collaborator

Thanks a ton!

@AdrianGonz97 AdrianGonz97 merged commit 0b1836e into huntabyte:main Mar 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Warn about deleted components on update" feature incorrectly displays a label
2 participants