Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update tasks example to be 1:1 with original #925

Merged
merged 9 commits into from
Mar 22, 2024

Conversation

Scooter1337
Copy link
Contributor

@Scooter1337 Scooter1337 commented Mar 20, 2024

Before submitting the PR, please make sure you do the following

  • If your PR isn't addressing a small fix (like a typo), it references an issue where it is discussed ahead of time and assigned to you. In many cases, features are absent for a reason.
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Format & lint the code with pnpm format and pnpm lint

Before:
ss1

After:
ss2

Copy link

changeset-bot bot commented Mar 20, 2024

⚠️ No Changeset found

Latest commit: 2c7dc3f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 20, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
shadcn-svelte ✅ Ready (View Log) Visit Preview 2c7dc3f

@huntabyte
Copy link
Owner

Hey there, thanks for taking the time to knock this out! I think we should update it to align with the original

@github-actions github-actions bot requested a deployment to Preview March 21, 2024 00:30 Abandoned
@Scooter1337
Copy link
Contributor Author

Hey there, thanks for taking the time to knock this out! I think we should update it to align with the original

Excuse me, I must have hallucinated the text. Fixed it, and made it 1:1 with the original.

@Scooter1337
Copy link
Contributor Author

Scooter1337 commented Mar 21, 2024

ss3

Columns now hidable via header, also added icons to Asc and Desc, matching the original.

@github-actions github-actions bot requested a deployment to Preview March 21, 2024 01:19 Abandoned
@Scooter1337
Copy link
Contributor Author

@huntabyte Could you look at my implementation of the 'Hide column' header functionality? I might be overcomplicating it.:

  • now passing tableModel and cell.id to DataTableColumnHeader
  • DataTableColumnHeader uses tableModel and cell.id to add the cell.id to hiddenCollumnIds
  • DataTableViewOptions now watches for changes in tableModel's hiddenCollumnIds

@Scooter1337
Copy link
Contributor Author

Found out that 'Desc' always toggled 'Ascending' if props.sort.order was undefined. As there is no 'set' but only toggle, we now toggle twice if 'Desc' and props.sort.order === undefined. (undefined -> 'Asc' -> 'Desc')

@Scooter1337 Scooter1337 changed the title docs: Add 'no tasks found' if there are 0 rows being displayed by the tasks example table. docs: Update tasks example to be 1:1 with original Mar 21, 2024
@huntabyte huntabyte merged commit 145de40 into huntabyte:main Mar 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants