-
-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Update tasks example to be 1:1 with original #925
Conversation
|
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Hey there, thanks for taking the time to knock this out! I think we should update it to align with the original |
…ement in react-shadcn with an if statement.
…ement in react-shadcn with an if statement.
Excuse me, I must have hallucinated the text. Fixed it, and made it 1:1 with the original. |
@huntabyte Could you look at my implementation of the 'Hide column' header functionality? I might be overcomplicating it.:
|
Found out that 'Desc' always toggled 'Ascending' if props.sort.order was undefined. As there is no 'set' but only toggle, we now toggle twice if 'Desc' and props.sort.order === undefined. (undefined -> 'Asc' -> 'Desc') |
Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.pnpm format
andpnpm lint
Before:
After: