⚠️ No Changeset found

Latest commit: 2c7dc3f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Hey there, thanks for taking the time to knock this out! I think we should update it to align with the original

Hey there, thanks for taking the time to knock this out! I think we should update it to align with the original

Excuse me, I must have hallucinated the text. Fixed it, and made it 1:1 with the original.

Columns now hidable via header, also added icons to Asc and Desc, matching the original.

@huntabyte Could you look at my implementation of the 'Hide column' header functionality? I might be overcomplicating it.:

• now passing tableModel and cell.id to DataTableColumnHeader
• DataTableColumnHeader uses tableModel and cell.id to add the cell.id to hiddenCollumnIds
• DataTableViewOptions now watches for changes in tableModel's hiddenCollumnIds

Found out that 'Desc' always toggled 'Ascending' if props.sort.order was undefined. As there is no 'set' but only toggle, we now toggle twice if 'Desc' and props.sort.order === undefined. (undefined -> 'Asc' -> 'Desc')