This repository was archived by the owner on Nov 2, 2024. It is now read-only.
Add config options to composer file. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hussainweb Pleaze you can apply for this PR ? |
hussainweb
suggested changes
Feb 1, 2018
There was a problem hiding this comment.
@softeg, thank you for suggesting these changes and I am sorry for the delay in getting back to you. I have requested a few changes before I can merge this in. Please take a look.
| @@ -140,6 +140,9 @@ protected function execute(InputInterface $input, OutputInterface $output) | |||
| $options['config'] = [ | |||
| 'sort-packages' => true, | |||
| 'optimize-autoloader' => true, | |||
| 'apcu-autoloader' => true, | |||
| 'secure-http' => false, | |||
There was a problem hiding this comment.
@softeg, I am not sure if this is a good idea to turn off by default. I know there are cases where secure-http must be disabled but I would rather letting the user do this rather than set it for them.
| @@ -140,6 +140,9 @@ protected function execute(InputInterface $input, OutputInterface $output) | |||
| $options['config'] = [ | |||
| 'sort-packages' => true, | |||
| 'optimize-autoloader' => true, | |||
| 'apcu-autoloader' => true, | |||
| 'secure-http' => false, | |||
| 'discard-changes' => true, | |||
There was a problem hiding this comment.
@softeg, I am thinking we should keep this as "stash" by default.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.