Skip to content

Conversation

gitveg
Copy link
Contributor

@gitveg gitveg commented Jan 22, 2025

添加build和markdown_lint。
本地仓库已测试,均可以正常运行。

Comment on lines 21 to 23
- uses: actions/setup-node@v4
with:
node-version: '20'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Node.js is not a dependence of mkdocs. There is no need to setup node.

Comment on lines 31 to 32
: > site/.nojekyll
echo -n 'oss.hust.openatom.club' > site/CNAME
Copy link
Member

@inscripoem inscripoem Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are settings regarding to GitHub Pages, which belongs to the deployment. You may remove these lines without consequences.

Copy link
Member

@inscripoem inscripoem Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the linting workflow, these is not a comprehensible log in the test run, showing an execution line and an exiting line.

More importantly, considering the site contains mostly Chinese content, we need a linting tool specifically built for this scenario. Try zhlint with the modified configuration from our club.

Please kindly take https://github.com/hust-open-atom-club/hust-mirrors/blob/master/.github/workflows/lint.yaml as reference.

Btw, I will recommend including a test run link (or more, if needed) with every workflow in the PR description.

@inscripoem
Copy link
Member

inscripoem commented Jan 22, 2025

Meanwhile, due to the logic of all the changes to the main branch should be made by PR, I think the trigger should be limited to PRs on main branch. You can check the discussion on Feishu.

@gitveg gitveg closed this Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants