fix: Don't set milestone if it's already been set with the right mile…

…stone (#82)
hustcer · Oct 25, 2024 · b79b30b · b79b30b
1 parent bc03c17
commit b79b30b
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/nu/milestone.nu b/nu/milestone.nu
@@ -37,8 +37,8 @@ export def 'milestone-bind-for-pr' [
     return
   }
   let selected = if ($milestone | is-empty) { guess-milestone-for-pr $repo $pr } else { $milestone }
+  let prevMilestone = gh pr view $pr --repo $repo --json 'milestone' | from json | get milestone?.title? | default '-'
   if $force {
-    let prevMilestone = gh pr view $pr --repo $repo --json 'milestone' | from json | get milestone?.title? | default '-'
     let shouldRemove = $prevMilestone != $selected
     if $dry_run and $shouldRemove {
       print $'(char nl)Would remove milestone for PR (ansi p)($pr)(ansi reset) in repository (ansi p)($repo)(ansi reset) ...'
@@ -48,6 +48,10 @@ export def 'milestone-bind-for-pr' [
       print $'(char nl)Milestone for PR (ansi p)($pr)(ansi reset) in repo (ansi p)($repo)(ansi reset) was already set to (ansi p)($prevMilestone)(ansi reset), will be ignored.'
     }
   }
+  if $prevMilestone == $selected {
+    print $'Milestone for PR (ansi p)($pr)(ansi reset) in repo (ansi p)($repo)(ansi reset) was already set to (ansi p)($selected)(ansi reset), will be ignored.'
+    return
+  }
   print $'(char nl)Setting milestone to (ansi p)($selected)(ansi reset) for PR (ansi p)($pr)(ansi reset) in repository (ansi p)($repo)(ansi reset) ...'
   # FIXME: GraphQL: Resource not accessible by integration (updatePullRequest)
   if not $dry_run {
@@ -77,8 +81,8 @@ export def 'milestone-bind-for-issue' [
   }
   let token = $env.GH_TOKEN? | default $env.GITHUB_TOKEN?
   let selected = if ($milestone | is-empty) { query-issue-closer-by-graphql $repo $issue $token | get closedBy?.milestone? | default '-' } else { $milestone }
+  let prevMilestone = gh issue view $issue --repo $repo --json 'milestone' | from json | get milestone?.title? | default '-'
   if $force {
-    let prevMilestone = gh issue view $issue --repo $repo --json 'milestone' | from json | get milestone?.title? | default '-'
     let shouldRemove = $prevMilestone != $selected
     if $dry_run and $shouldRemove {
       print $'(char nl)Would remove milestone for Issue (ansi p)($issue)(ansi reset) in repository (ansi p)($repo)(ansi reset) ...'
@@ -92,6 +96,10 @@ export def 'milestone-bind-for-issue' [
     print $'No milestone found for issue (ansi p)($issue)(ansi reset) in repository (ansi p)($repo)(ansi reset).'
     return
   }
+  if $prevMilestone == $selected {
+    print $'Milestone for Issue (ansi p)($issue)(ansi reset) in repo (ansi p)($repo)(ansi reset) was already set to (ansi p)($selected)(ansi reset), will be ignored.'
+    return
+  }
   print $'(char nl)Setting milestone to (ansi p)($selected)(ansi reset) for Issue (ansi p)($issue)(ansi reset) in repository (ansi p)($repo)(ansi reset) ...'
   # FIXME: GraphQL: Resource not accessible by integration (updatePullRequest)
   if not $dry_run {