chore: consolidate NavigationView keyboard and gamepad handling #665

United600 · 2025-09-03T15:27:05Z

Moves the NavigationView keyboard interaction features from the behavior to the custom control.
Initially, I considered converting it to an extension, but since the ListViewExtension PR moves the folder, I consolidated it instead.

Adds dependency properties to CustomNavigationView for access keys, keyboard accelerators and styles for the back, close, pane toggle, pane search, and settings buttons
Fixes gamepad support for the search button, which previously only worked in expanded display mode
Improves the Overlay layout, removing the need to handle it on code
Improves the Overlay with light-dismiss UI support (Xbox only)
Adds new animations to the NavigationView sidebar and content
Removes obsolete NavigationViewKeyboardBehavior

P.S. We should consider renaming the control to something like NavigationViewEx.

United600 · 2025-09-03T15:32:14Z

Screenbox/Controls/NavigationViewEx.cs

+            splitViewGrid.Children.Add(_overlayRoot);
+        }
+
+        if (_splitView?.FindDescendant<Border>(b => b.Name == "ContentBackground") is { } contentBackground)


I can't find this control? What is supposed to do?

That is probably a regression. It was a custom element in the CustomNavigationView template and was supposed to be the background of the content pane. Setting the background of that Border helps blend the nav bar transition, as demonstrated in the video in #189. I don't remember when the ContentBackground was removed. 🤔

I found it. It was the custom SplitView template #341. I removed it :)

I think code related to ContentBackground is safe to delete.

Oh yeah, I can see what you’re saying about the background blend effect in the nav bar transition. Maybe we can investigate how to bring it back, unless it requires adding a custom SplitView style.

The problem was the custom SplitView style doesn't follow the theme change. I think we can add the Border behind the content pane in code behind, without touching the SplitView template. We can listen to theme change events on the NavigationViewEx and change the border background accordingly.

Or we could just "cheat" and simply remove the background entirely, like the system Settings app 😉.

Gravacao.2025-09-27.161425.mp4

The problem was the custom SplitView style doesn't follow the theme change. I think we can add the Border behind the content pane in code behind, without touching the SplitView template. We can listen to theme change events on the NavigationViewEx and change the border background accordingly.

Not sure about adding yet another background layer. Right now, I'm already darkening the light dismiss background (only on Xbox) just to fix the layer missing on Xbox. I could probably just always set the content light dismiss layer to collapsed.

Or we could just "cheat" and simply remove the background entirely, like the system Settings app 😉.

Honestly that may be the way. I remember I was against it for some reason. But it looks good now so why not.

Honestly that may be the way. I remember I was against it for some reason. But it looks good now so why not.

It doesn't look too good on the compact mode, probably why the system settings app skips it and switches straight to minimal mode.

Copilot

Pull Request Overview

This PR refactors NavigationView keyboard functionality by moving behavior-based keyboard interactions into a custom control and consolidating styling resources. The change improves maintainability by reducing behavior dependencies and provides a more cohesive API for customizing NavigationView buttons.

Moves keyboard access keys and accelerators from NavigationViewKeyboardBehavior to CustomNavigationView dependency properties
Consolidates NavigationView styling resources into a dedicated XAML file
Adds gamepad Y button support for search functionality across all display modes

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
Screenbox/Styles/NavigationView.xaml	New dedicated resource dictionary for NavigationView styling with acrylic backgrounds and animated search button style
Screenbox/Screenbox.csproj	Project file updates to include new files and remove obsolete behavior class
Screenbox/Pages/MainPage.xaml.cs	Removes gamepad Y button handling and helper method since functionality moved to custom control
Screenbox/Pages/MainPage.xaml	Updates to use new resource dictionary and CustomNavigationView properties, removes behavior usage
Screenbox/Controls/Interactions/NavigationViewKeyboardBehavior.cs	Entire file deleted as functionality moved to CustomNavigationView
Screenbox/Controls/CustomNavigationView.cs	Major refactor adding keyboard interaction features, overlay improvements, and animation enhancements
Screenbox/Controls/CustomNavigationView.Properties.cs	New partial class containing dependency property definitions for the custom control

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Screenbox/Controls/CustomNavigationView.cs

Screenbox/Controls/CustomNavigationView.Properties.cs

United600 · 2025-09-05T20:58:40Z

We should add an ObservableProperty (or improve the PlayerVisible) to track player visibility, which can be bound to the Frame. This would reduce the visual tree when the play queue is empty. Also it should improve the app cold launch.

<controls:CustomNavigationView.Overlay>
-    <Frame x:Name="PlayerFrame" />
+    <Frame x:Name="PlayerFrame" Visibility="{x:Bind ViewModel.PlayerVisible, Mode=OneWay}" />
</controls:CustomNavigationView.Overlay>

Co-authored-by: Copilot <[email protected]>

Copilot

Pull Request Overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 7 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Screenbox/Controls/NavigationViewEx.cs

Screenbox/Controls/NavigationViewEx.Properties.cs

Copilot · 2025-09-24T04:39:02Z

Screenbox/Controls/NavigationViewEx.Properties.cs

+    /// Identifies the <see cref="SettingsItemStyle"/> dependency property.
+    /// </summary>
+    public static readonly DependencyProperty SettingsItemStyleProperty = DependencyProperty.Register(
+        nameof(SettingsItemStyle), typeof(Style), typeof(NavigationViewEx), new PropertyMetadata(null, OnSettingsItemStylePropertyChanged));


The dependency property is missing the CloseButtonStyle property registration. There should be a CloseButtonStyleProperty defined between the close button access key properties and the pane toggle button properties.

dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Sep 3, 2025

United600 requested a review from Copilot September 3, 2025 15:27

United600 commented Sep 3, 2025

View reviewed changes

Copilot AI reviewed Sep 3, 2025

View reviewed changes

Screenbox/Controls/CustomNavigationView.cs Show resolved Hide resolved

Screenbox/Controls/CustomNavigationView.Properties.cs Outdated Show resolved Hide resolved

United600 changed the title ~~chore: move the navigation view behavior to the control~~ chore: consolidate NavigationView keyboard and gamepad handling Sep 3, 2025

United600 force-pushed the United600/nav-view-custom branch 2 times, most recently from 474a644 to 3bd3bb3 Compare September 6, 2025 14:53

United600 and others added 8 commits September 24, 2025 00:04

refactor navigation view keyboard behavior

c8c1e39

refactor navigation view search gamepad support

7b7f515

refactor CustomNavigationView properties and improve animations

34c928d

add customization for the navigation view settings item

4f6a156

fix XML documentation comment

e7750ff

Co-authored-by: Copilot <[email protected]>

add light-dismiss support to overlay grid

9677b2e

renamed content animation sets and minor duration and easing tweaks

41b1be1

improve overlay documentation

c54fc90

United600 force-pushed the United600/nav-view-custom branch from 38f7c05 to c54fc90 Compare September 23, 2025 23:04

rename CustomNavigationView to NavigationViewEx and sealed the class

bf2c156

huynhsontung requested a review from Copilot September 24, 2025 04:37

Copilot AI reviewed Sep 24, 2025

View reviewed changes

Uh oh!

chore: consolidate NavigationView keyboard and gamepad handling #665

Are you sure you want to change the base?

chore: consolidate NavigationView keyboard and gamepad handling #665

Conversation

United600 commented Sep 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

huynhsontung Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

United600 commented Sep 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

United600 commented Sep 3, 2025 •

edited

Loading

huynhsontung Sep 24, 2025 •

edited

Loading

United600 commented Sep 5, 2025 •

edited

Loading