Skip to content

CI: remove dep_gen workaround and disable dump_passes debug flag#675

Merged
zhangqi-chen merged 1 commit into
hw-native-sys:mainfrom
zhangqi-chen:ci/remove-dep-gen-workaround
Jul 2, 2026
Merged

CI: remove dep_gen workaround and disable dump_passes debug flag#675
zhangqi-chen merged 1 commit into
hw-native-sys:mainfrom
zhangqi-chen:ci/remove-dep-gen-workaround

Conversation

@zhangqi-chen

Copy link
Copy Markdown
Collaborator

Summary

  • ci.yml: drop the # ci: no-dep-gen directive handling (marker grep + depgen_args) from the a2a3 test loop — added by perf(qwen3-14b decode): fuse rope+attn+softmax into one fa_fused kernel #656 as a workaround, now redundant.
  • qwen3-14b decode_layer.py: remove the deprecated --no-dep-gen CLI option and its stale references. enable_dep_gen stays force-disabled in-kernel (full-occupancy pl.system.syncall is incompatible with dep_gen, pypto#1931), so the flag was already a no-op.
  • dump_passes=True -> False across model entrypoints (leftover debug flag): v3_2 decode_back / decode_front / prefill_back, qwen3-32b decode / decode_4d / prefill_draft, qwen3-14b decode_layer.

Related Issues

Relates to pypto#1931 (dep_gen vs full-occupancy syncall).

Revert the PR hw-native-sys#656 dep_gen CI workaround now that it is redundant, and
turn off the leftover dump_passes debug flag across model entrypoints.

- ci.yml: drop the `# ci: no-dep-gen` directive handling (marker grep +
  depgen_args) from the a2a3 loop
- qwen3-14b decode_layer.py: remove the deprecated `--no-dep-gen` CLI
  option and its stale references; enable_dep_gen stays force-disabled
  in-kernel (full-occupancy syncall vs dep_gen, pypto#1931)
- dump_passes=True -> False in v3_2 decode_back/decode_front/prefill_back,
  qwen3-32b decode/decode_4d/prefill_draft, and qwen3-14b decode_layer
@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f56d3848-0df1-4f9a-bfd9-b80daa917cad

📥 Commits

Reviewing files that changed from the base of the PR and between 98271e1 and 3e77083.

📒 Files selected for processing (8)
  • .github/workflows/ci.yml
  • models/deepseek/v3_2/deepseek_v3_2_decode_back.py
  • models/deepseek/v3_2/deepseek_v3_2_decode_front.py
  • models/deepseek/v3_2/deepseek_v3_2_prefill_back.py
  • models/qwen3/14b/decode_layer.py
  • models/qwen3/32b/qwen3_32b_decode.py
  • models/qwen3/32b/qwen3_32b_decode_4d.py
  • models/qwen3/32b/qwen3_32b_prefill_draft.py

📝 Walkthrough

Walkthrough

This PR removes the CI workflow's conditional depgen_args handling in the a2a3 job, deletes the deprecated --no-dep-gen CLI option and its CI marker comment from a qwen3 14b decode script, and switches dump_passes from True to False in compile_cfg/RunConfig across multiple model example entrypoints.

Changes

Compile config and CI toggle cleanup

Layer / File(s) Summary
Remove depgen_args from CI a2a3 job
.github/workflows/ci.yml
Deletes the conditional depgen_args construction triggered by the # ci: no-dep-gen marker and stops passing ${depgen_args[@]} to python in both multi-device and single-device branches.
Remove --no-dep-gen CLI option and disable pass dumping in qwen3 14b decode_layer
models/qwen3/14b/decode_layer.py
Deletes the top-of-file CI marker comment and the deprecated --no-dep-gen argparse option, and sets dump_passes=False in both the run_jit invocation and the --validate-fwd RunConfig.
Disable dump_passes in remaining model entrypoints
models/deepseek/v3_2/deepseek_v3_2_decode_back.py, models/deepseek/v3_2/deepseek_v3_2_decode_front.py, models/deepseek/v3_2/deepseek_v3_2_prefill_back.py, models/qwen3/32b/qwen3_32b_decode.py, models/qwen3/32b/qwen3_32b_decode_4d.py, models/qwen3/32b/qwen3_32b_prefill_draft.py
Changes compile_cfg["dump_passes"] from True to False in each run(...) call's __main__ execution path.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

Poem

A rabbit hops through configs anew,
No dep-gen flags left to chew,
Passes stay quiet, no dumps in sight,
CI runs cleaner, args set just right,
Thump-thump goes my joyful review! 🐇✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the CI cleanup and debug-flag removal reflected in the changeset.
Description check ✅ Passed The description accurately matches the CI and model-entrypoint changes described in the summary.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request disables the dumping of compiler passes (setting dump_passes to False) across several DeepSeek and Qwen3 model configuration files. Additionally, in models/qwen3/14b/decode_layer.py, the deprecated --no-dep-gen command-line argument, its associated CI marker, and related comments have been removed. As there are no review comments, I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@zhangqi-chen zhangqi-chen merged commit 36f94e7 into hw-native-sys:main Jul 2, 2026
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant