chore: update to rust 1.93.1, enable a few more clippy lints#2637
Open
MingweiSamuel wants to merge 1 commit intomainfrom
Open
chore: update to rust 1.93.1, enable a few more clippy lints#2637MingweiSamuel wants to merge 1 commit intomainfrom
MingweiSamuel wants to merge 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Enables additional workspace-level Clippy lints and updates a handful of call sites to satisfy the new lint set (primarily manual_let_else, needless_for_each, and manual_string_new), improving code consistency and lint signal across the repo.
Changes:
- Enabled several additional Clippy lints in
[workspace.lints.clippy]. - Refactored a set of
if let/matchpatterns intolet ... elseandfor_eachintoforloops. - Replaced
"...".to_owned()empty-string constructions withString::new()in a few places.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Cargo.toml | Enables additional Clippy lints at the workspace level. |
| lattices/src/algebra.rs | Updates tests to use String::new() for empty strings. |
| hydro_test/examples/http_hello.rs | Uses let ... else for extracting TCP port. |
| hydro_test/examples/http_counter.rs | Uses let ... else for extracting TCP port. |
| hydro_lang/src/viz/json.rs | Uses let ... else to destructure JSON objects. |
| hydro_lang/src/sim/graph.rs | Replaces for_each chains with for loops. |
| hydro_lang/src/sim/compiled.rs | Replaces for_each with for loops over hooks. |
| hydro_lang/src/sim/builder.rs | Uses String::new() in fallback location tuple. |
| hydro_lang/src/location/cluster.rs | Uses let ... else to destructure LocationId. |
| hydro_lang/src/deploy/deploy_runtime_containerized.rs | Logs the result when handshake frames are missing/fail. |
| hydro_lang/src/deploy/deploy_graph_containerized_ecs.rs | Uses let ... else to destructure LocationId. |
| hydro_lang/src/compile/ir/mod.rs | Replaces for_each with for loops for traversal. |
| benches/benches/futures.rs | Refactors a boolean match into if/else in poll. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Deploying hydro with
|
| Latest commit: |
d32df01
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4bde735b.hydroflow.pages.dev |
| Branch Preview URL: | https://more-clippy.hydroflow.pages.dev |
be8cf91 to
1348408
Compare
1348408 to
512e0fb
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 20 out of 20 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
95bd60b to
7ab7422
Compare
7ab7422 to
d32df01
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i love lints
Mainly
manual_let_else,needless_for_each, others