Skip to content

chore: update to rust 1.93.1, enable a few more clippy lints#2637

Open
MingweiSamuel wants to merge 1 commit intomainfrom
more-clippy
Open

chore: update to rust 1.93.1, enable a few more clippy lints#2637
MingweiSamuel wants to merge 1 commit intomainfrom
more-clippy

Conversation

@MingweiSamuel
Copy link
Member

i love lints

Mainly manual_let_else, needless_for_each, others

Copilot AI review requested due to automatic review settings March 6, 2026 22:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Enables additional workspace-level Clippy lints and updates a handful of call sites to satisfy the new lint set (primarily manual_let_else, needless_for_each, and manual_string_new), improving code consistency and lint signal across the repo.

Changes:

  • Enabled several additional Clippy lints in [workspace.lints.clippy].
  • Refactored a set of if let/match patterns into let ... else and for_each into for loops.
  • Replaced "...".to_owned() empty-string constructions with String::new() in a few places.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
Cargo.toml Enables additional Clippy lints at the workspace level.
lattices/src/algebra.rs Updates tests to use String::new() for empty strings.
hydro_test/examples/http_hello.rs Uses let ... else for extracting TCP port.
hydro_test/examples/http_counter.rs Uses let ... else for extracting TCP port.
hydro_lang/src/viz/json.rs Uses let ... else to destructure JSON objects.
hydro_lang/src/sim/graph.rs Replaces for_each chains with for loops.
hydro_lang/src/sim/compiled.rs Replaces for_each with for loops over hooks.
hydro_lang/src/sim/builder.rs Uses String::new() in fallback location tuple.
hydro_lang/src/location/cluster.rs Uses let ... else to destructure LocationId.
hydro_lang/src/deploy/deploy_runtime_containerized.rs Logs the result when handshake frames are missing/fail.
hydro_lang/src/deploy/deploy_graph_containerized_ecs.rs Uses let ... else to destructure LocationId.
hydro_lang/src/compile/ir/mod.rs Replaces for_each with for loops for traversal.
benches/benches/futures.rs Refactors a boolean match into if/else in poll.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Mar 6, 2026

Deploying hydro with  Cloudflare Pages  Cloudflare Pages

Latest commit: d32df01
Status: ✅  Deploy successful!
Preview URL: https://4bde735b.hydroflow.pages.dev
Branch Preview URL: https://more-clippy.hydroflow.pages.dev

View logs

@MingweiSamuel MingweiSamuel changed the title style: enable a few more clippy lints chore: update to rust 1.93.1, enable a few more clippy lints Mar 6, 2026
@MingweiSamuel MingweiSamuel requested a review from shadaj March 6, 2026 23:14
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 20 out of 20 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@MingweiSamuel MingweiSamuel force-pushed the more-clippy branch 2 times, most recently from 95bd60b to 7ab7422 Compare March 9, 2026 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants