Skip to content

fix(deps): bump slotmap minimum version to 1.1.0#2640

Merged
MingweiSamuel merged 2 commits intomainfrom
copilot/update-cargo-dependencies-to-1-1-0
Mar 6, 2026
Merged

fix(deps): bump slotmap minimum version to 1.1.0#2640
MingweiSamuel merged 2 commits intomainfrom
copilot/update-cargo-dependencies-to-1-1-0

Conversation

Copy link
Contributor

Copilot AI commented Mar 6, 2026

slotmap introduced const fn from_ffi in 1.1.0, but all three crates were pinned to 1.0.0, causing compilation failures when that API is used.

Changes

  • Bumped slotmap from 1.0.01.1.0 in:
    • dfir_rs/Cargo.toml
    • dfir_lang/Cargo.toml
    • hydro_lang/Cargo.toml

The resolved version in Cargo.lock is already 1.1.1, so no lock file churn is expected.

Original prompt

This section details on the original issue you should resolve

<issue_title>bug(hydro_lang): slotmap requires min version 1.1.0 for const fn from_ffi</issue_title>
<issue_description>Please update all cargo.toml dependencies to depend on 1.1.0 instead of lower 1.0.* versions</issue_description>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@MingweiSamuel MingweiSamuel changed the title [WIP] Update cargo.toml dependencies to require version 1.1.0 fix(hydro_lang): update min slotmap version to 1.1.0 Mar 6, 2026
Co-authored-by: MingweiSamuel <6778341+MingweiSamuel@users.noreply.github.com>
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Mar 6, 2026

Deploying hydro with  Cloudflare Pages  Cloudflare Pages

Latest commit: a844f1b
Status: ✅  Deploy successful!
Preview URL: https://1f531e19.hydroflow.pages.dev
Branch Preview URL: https://copilot-update-cargo-depende.hydroflow.pages.dev

View logs

Copilot AI changed the title fix(hydro_lang): update min slotmap version to 1.1.0 fix(deps): bump slotmap minimum version to 1.1.0 Mar 6, 2026
@MingweiSamuel MingweiSamuel marked this pull request as ready for review March 6, 2026 23:05
Copilot AI review requested due to automatic review settings March 6, 2026 23:05
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR bumps the minimum slotmap dependency version from 1.0.0 to 1.1.0 across three crates (dfir_rs, dfir_lang, hydro_lang) to fix compilation failures when using const fn from_ffi, which was introduced in slotmap 1.1.0. The resolved version in Cargo.lock is already 1.1.1, so no lock file changes are needed.

Changes:

  • Bumped slotmap minimum version from 1.0.0 to 1.1.0 in all three crates that depend on it.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
dfir_rs/Cargo.toml Bump slotmap from "1.0.0" to "1.1.0"
dfir_lang/Cargo.toml Bump slotmap from "1.0.0" to "1.1.0" (with serde feature)
hydro_lang/Cargo.toml Bump slotmap from "1.0.0" to "1.1.0" (with serde feature)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@MingweiSamuel MingweiSamuel enabled auto-merge (squash) March 6, 2026 23:14
@MingweiSamuel MingweiSamuel merged commit 45bf796 into main Mar 6, 2026
26 checks passed
@MingweiSamuel MingweiSamuel deleted the copilot/update-cargo-dependencies-to-1-1-0 branch March 6, 2026 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(hydro_lang): slotmap requires min version 1.1.0 for const fn from_ffi

4 participants