fix(deps): bump slotmap minimum version to 1.1.0#2640
Merged
MingweiSamuel merged 2 commits intomainfrom Mar 6, 2026
Merged
Conversation
Co-authored-by: MingweiSamuel <6778341+MingweiSamuel@users.noreply.github.com>
Deploying hydro with
|
| Latest commit: |
a844f1b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1f531e19.hydroflow.pages.dev |
| Branch Preview URL: | https://copilot-update-cargo-depende.hydroflow.pages.dev |
Copilot
AI
changed the title
fix(hydro_lang): update min slotmap version to 1.1.0
fix(deps): bump Mar 6, 2026
slotmap minimum version to 1.1.0
MingweiSamuel
approved these changes
Mar 6, 2026
shadaj
approved these changes
Mar 6, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR bumps the minimum slotmap dependency version from 1.0.0 to 1.1.0 across three crates (dfir_rs, dfir_lang, hydro_lang) to fix compilation failures when using const fn from_ffi, which was introduced in slotmap 1.1.0. The resolved version in Cargo.lock is already 1.1.1, so no lock file changes are needed.
Changes:
- Bumped
slotmapminimum version from1.0.0to1.1.0in all three crates that depend on it.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
dfir_rs/Cargo.toml |
Bump slotmap from "1.0.0" to "1.1.0" |
dfir_lang/Cargo.toml |
Bump slotmap from "1.0.0" to "1.1.0" (with serde feature) |
hydro_lang/Cargo.toml |
Bump slotmap from "1.0.0" to "1.1.0" (with serde feature) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
slotmapintroducedconst fn from_ffiin1.1.0, but all three crates were pinned to1.0.0, causing compilation failures when that API is used.Changes
slotmapfrom1.0.0→1.1.0in:dfir_rs/Cargo.tomldfir_lang/Cargo.tomlhydro_lang/Cargo.tomlThe resolved version in
Cargo.lockis already1.1.1, so no lock file churn is expected.Original prompt
slotmaprequires min version1.1.0forconst fn from_ffi#2639✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.