fix(hydroflow): cleanup temp tcp networking code, fix race condition fix #1458 #1446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MingweiSamuel
force-pushed
the
tcp-temp-fix
branch
from
2ce671b
to
a977564
Compare
MingweiSamuel
changed the title
MingweiSamuel
force-pushed
the
tcp-temp-fix
branch
2 times, most recently
from
bced4ad
to
99846df
Compare
hydro-project#1458 only spawn one task to prevent races between tasks
MingweiSamuel
force-pushed
the
tcp-temp-fix
branch
from
99846df
to
006890f
Compare
| @@ -74,6 +73,7 @@ pub type TcpFramedSink<T> = Sender<(T, SocketAddr)>; | |||
| pub type TcpFramedStream<Codec: Decoder> = | |||
| Receiver<Result<(<Codec as Decoder>::Item, SocketAddr), <Codec as Decoder>::Error>>; | |||
|
|
|||
| // TODO(mingwei): this temporary code should be replaced with a properly thought out networking system. | |||
| continue; | ||
| // Calling methods in a loop, futures must be cancel-safe. | ||
| select! { | ||
| biased; |
There was a problem hiding this comment.
It will be helpful to document why biased is necessary.
| // Send outgoing messages. | ||
| msg_send = recv_egress.next() => { | ||
| let Some((payload, peer_addr)) = msg_send else { | ||
| continue; |
There was a problem hiding this comment.
In what condition is this continue called?
| } | ||
| } | ||
| }); | ||
| let (send_egress, mut recv_egress) = unsync_channel::<(T, SocketAddr)>(None); |
There was a problem hiding this comment.
Curious, what was wrong with tx and rx?
| loop { | ||
| // Calling methods in a loop, futures must be cancel-safe. | ||
| select! { | ||
| biased; |
There was a problem hiding this comment.
Ditto on why biased is necessary.
|
Nice. Mostly LGTM, just a few questions for clarity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
consolidate into one task to prevent races