Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add decouple and simple test and two_pc #1453

Merged
merged 12 commits into from
Oct 8, 2024

Conversation

IceCoooola
Copy link
Contributor

No description provided.

@IceCoooola IceCoooola changed the title add decouple and simple test feat: add decouple and simple test Sep 14, 2024
@IceCoooola IceCoooola changed the title feat: add decouple and simple test feat: add decouple and simple test and two_pc Sep 20, 2024
@IceCoooola
Copy link
Contributor Author

upload two_pc

@shadaj
Copy link
Member

shadaj commented Oct 1, 2024

@IceCoooola you will need to rebase because we made a couple of breaking changes. In particular, you can now just call .self_id() on a Cluster to get that value, which should simplify some of your logic.

@IceCoooola
Copy link
Contributor Author

@shadaj rebased!

Copy link
Member

@shadaj shadaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass!

hydroflow_plus/src/stream.rs Outdated Show resolved Hide resolved
hydroflow_plus/src/stream.rs Outdated Show resolved Hide resolved
hydroflow_plus_test/src/cluster/simple_cluster.rs Outdated Show resolved Hide resolved
hydroflow_plus_test/src/cluster/two_pc.rs Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
@IceCoooola
Copy link
Contributor Author

@shadaj fixed! could you review it again? thank you!

hydroflow_plus/src/stream.rs Outdated Show resolved Hide resolved
Copy link
Member

@shadaj shadaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🎉

@shadaj shadaj merged commit 2141c5f into hydro-project:main Oct 8, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants