Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: use different target dir for rust-analyzer to prevent thrashing with cargo #1460

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

build: use different target dir for rust-analyzer to prevent thrashing with cargo #1460

wants to merge 1 commit into from

Conversation

MingweiSamuel
Copy link
Member

@MingweiSamuel MingweiSamuel commented Sep 23, 2024 •
edited
Loading

Might only be a problem on windows?

@MingweiSamuel
Copy link
Member Author

MingweiSamuel commented Sep 23, 2024 •
edited
Loading

Hmm, this might use up more disk space for @jhellerstein
Seems to use under 5gb for the extra target dir, out of ~50gb..

@shadaj
Copy link
Member

shadaj commented Sep 23, 2024

Wouldn't disabling the python feature be sufficient to prevent thrashing?

@MingweiSamuel
Copy link
Member Author

Not on my windows machine, both builds still invalidated each other

@shadaj
Copy link
Member

shadaj commented Sep 23, 2024

Maybe we should inspect all our build.rs, similar issues were happening in BLAKE3-team/BLAKE3#413

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shadaj shadaj Awaiting requested review from shadaj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MingweiSamuel @shadaj