Refactor code quality improvements: variable naming, dead code removal, and React Context fix

[Copilot]

Applied nitpick refactoring suggestions to improve code clarity and fix incorrect React Context API usage.

Changes

app/_lib/server.ts

• Renamed typeMatchCategory → matchedType for clarity
• Removed single-use constant MATCHED_TYPE_BOTH, inlined as 'both'
• Extracted getOptionIdentifier() helper to deduplicate option name fallback chain

app/(main)/_context/user.tsx

• Fixed: <UserContext> → <UserContext.Provider> (incorrect API usage)

app/(main)/instance/layout.tsx

• Replaced isError?.message with static error text (isError is boolean, not Error object)
• Extracted getTabFromPathname() to eliminate duplicate pathname parsing logic
• Fixed JSX naming: <tab.icon /> → const Icon = tab.icon; <Icon />

app/(main)/layout.tsx

• Removed hardcoded variant = 'inset' and unreachable conditional branch
• Simplified to single code path (removed 13 lines of dead code)

// Before
const variant = 'inset';
{variant != 'inset' ? <DeadCode /> : <ActualCode />}

// After
<ActualCode />

Original prompt

Please apply the following diffs and create a pull request.
Once the PR is ready, give it a title based on the messages of the fixes being applied.

[{"message":"[nitpick] The variable name 'typeMatchCategory' is verbose and could be simplified to 'matchedType' for better readability without losing clarity.","fixFiles":[{"filePath":"app/_lib/server.ts","diff":"diff --git a/app/_lib/server.ts b/app/_lib/server.ts\n--- a/app/_lib/server.ts\n+++ b/app/_lib/server.ts\n@@ -55,23 +55,23 @@\n \n     // Default to supporting both types\n     option.supported_types = ['container', 'virtual-machine'];\n-    let typeMatchCategory: 'both' | 'container' | 'virtual-machine' = MATCHED_TYPE_BOTH;\n+    let matchedType: 'both' | 'container' | 'virtual-machine' = MATCHED_TYPE_BOTH;\n     // Check for container-only patterns\n     if (\n       TYPE_PATTERNS.container.some((pattern) => textToCheck.includes(pattern))\n     ) {\n       option.supported_types = ['container'];\n-      typeMatchCategory = 'container';\n+      matchedType = 'container';\n     }\n     // Check for VM-only patterns\n     else if (\n       TYPE_PATTERNS.vm.some((pattern) => textToCheck.includes(pattern))\n     ) {\n       option.supported_types = ['virtual-machine'];\n-      typeMatchCategory = 'virtual-machine';\n+      matchedType = 'virtual-machine';\n     }\n     // Warn if no pattern matched and falling back to both\n-    if (typeMatchCategory === MATCHED_TYPE_BOTH && process.env.NODE_ENV === 'development') {\n+    if (matchedType === MATCHED_TYPE_BOTH && process.env.NODE_ENV === 'development') {\n       console.warn(\n         `[processOption] Option ${option.name || option.key || '[unknown key]'} uses the default 'both' instance types due to unmatched pattern:`,\n         textToCheck\n"}]},{"message":"[nitpick] The condition check should use a more descriptive variable name or inline the constant value for better code clarity. Consider using 'matchedType === 'both'' instead.","fixFiles":[{"filePath":"app/_lib/server.ts","diff":"diff --git a/app/_lib/server.ts b/app/_lib/server.ts\n--- a/app/_lib/server.ts\n+++ b/app/_lib/server.ts\n@@ -45,8 +45,6 @@\n   };\n \n   // Helper to process a single option\n-  const MATCHED_TYPE_BOTH = 'both' as const;\n-\n   const processOption = (option: ConfigOption) => {\n     const textToCheck = [option.condition, option.shortdesc, option.longdesc]\n       .filter(Boolean)\n@@ -55,23 +53,23 @@\n \n     // Default to supporting both types\n     option.supported_types = ['container', 'virtual-machine'];\n-    let typeMatchCategory: 'both' | 'container' | 'virtual-machine' = MATCHED_TYPE_BOTH;\n+    let matchedType: 'both' | 'container' | 'virtual-machine' = 'both';\n     // Check for container-only patterns\n     if (\n       TYPE_PATTERNS.container.some((pattern) => textToCheck.includes(pattern))\n     ) {\n       option.supported_types = ['container'];\n-      typeMatchCategory = 'container';\n+      matchedType = 'container';\n     }\n     // Check for VM-only patterns\n     else if (\n       TYPE_PATTERNS.vm.some((pattern) => textToCheck.includes(pattern))\n     ) {\n       option.supported_types = ['virtual-machine'];\n-      typeMatchCategory = 'virtual-machine';\n+      matchedType = 'virtual-machine';\n     }\n     // Warn if no pattern matched and falling back to both\n-    if (typeMatchCategory === MATCHED_TYPE_BOTH && process.env.NODE_ENV === 'development') {\n+    if (matchedType === 'both' && process.env.NODE_ENV === 'development') {\n       console.warn(\n         `[processOption] Option ${option.name || option.key || '[unknown key]'} uses the default 'both' instance types due to unmatched pattern:`,\n         textToCheck\n"}]},{"message":"[nitpick] This constant is only used once and creates unnecessary indirection. Consider removing it and using the literal 'both' directly in the code.","fixFiles":[{"filePath":"app/_lib/server.ts","diff":"diff --git a/app/_lib/server.ts b/app/_lib/server.ts\n--- a/app/_lib/server.ts\n+++ b/app/_lib/server.ts\n@@ -45,8 +45,6 @@\n   };\n \n   // Helper to process a single option\n-  const MATCHED_TYPE_BOTH = 'both' as const;\n-\n   const processOption = (option: ConfigOption) => {\n     const textToCheck = [option.condition, option.shortdesc, option.longdesc]\n       .filter(Boolean)\n@@ -55,7 +53,7 @@\n \n     // Default to supporting both types\n     option.supported_types = ['container', 'virtual-machine'];\n-    let typeMatchCategory: 'both' | 'container' | 'virtual-machine' = MATCHED_TYPE_BOTH;\n+    let typeMatchCategory: 'both' | 'container' | 'virtual-machine' = 'both';\n     // Check for container-only patterns\n     if (\n       TYPE_PATTERNS.container.some((pattern) => textToCheck.includes(pattern))\n"}]},{"message":"[nitpick] The fallback chain 'option.name || option.key || '[unknown key]'' could be extracted to a helper function for better readability and reusability.","fixFiles":[{"filePath":"app/_lib/server.ts","diff":"diff --git a/app/_l...

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.