Skip to content
This repository has been archived by the owner on Nov 29, 2018. It is now read-only.

feat(url): 'www'-initiated URL extractor #51

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jalemany1
Copy link

Necessary to detect URLs initiated by 'www'

Copy link
Owner

@hypeJunction hypeJunction left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure it's necessary?

@jalemany1
Copy link
Author

I had to include it in an Elgg instance where 2 users wrote manually an URL. This inclusion is insignificant, but handle this scenario.

@hypeJunction
Copy link
Owner

Just normalize the URL before passing it to the instance, IMO

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants