-
Notifications
You must be signed in to change notification settings - Fork 204
update browser context based on provider, update hyperbrowser SDK ver… #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -137,9 +137,16 @@ export class HyperAgent<T extends BrowserProviders = "Local"> { | |
| public async initBrowser(): Promise<Browser> { | ||
| if (!this.browser) { | ||
| this.browser = await this.browserProvider.start(); | ||
| this.context = await this.browser.newContext({ | ||
| viewport: null, | ||
| }); | ||
| if ( | ||
| this.browserProviderType === "Hyperbrowser" && | ||
| this.browser.contexts().length > 0 | ||
| ) { | ||
| this.context = this.browser.contexts()[0]; | ||
| } else { | ||
| this.context = await this.browser.newContext({ | ||
| viewport: null, | ||
| }); | ||
| } | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bug: Init script not applied to existing Hyperbrowser pagesWhen reusing an existing Hyperbrowser context, |
||
|
|
||
| // Inject script to track event listeners | ||
| await this.context.addInitScript(() => { | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.