Push to PRD #26
Open
Push to PRD #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactors the SDK validators to use classes instead of a single file with repeating methods. - Create base abstract SchemaValidator with AJV integration - Implement specialized validators: - MetadataValidator with nested schema support - ClaimDataValidator for hypercert claims - AllowlistValidator for merkle tree entries - MerkleProofValidator for proof verification - Add comprehensive test suite for all validators - Maintain backwards compatibility through legacy API wrapper - Improve error handling with structured ValidationError type - Introduce ValidatorFactory for consistent instantiation
Add property validator that also specifically checks for geoJSONs. The pattern should be scalable to multiple specific types of properties. Updated the metadata validator to validate properties in metadata when applicable. Add and update test suite
Updates thresholds to represent current coverage
Support for geoJSON in metadata
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
replaces api submodule with endpoint call to build orval client
support for latest properties types
|
🎉 This PR is included in version 2.5.0-beta.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
fixes typo in geoJSON mime type. Bumps coverage threshold
MIME type validation formattes
|
🎉 This PR is included in version 2.5.0-beta.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Implements the AttestationValidator class to perform a deeper validation EAS attestations according to our spec. Attestation should at least contain a chainID and contractAddress for a chain and contract that we support. The tokenID in the attestaion should point to an hypercert claimID. To support these schemas, the SchemaValidator has been split into an Ajv and Zod validator. Additionally, utils/tokenIds.ts has been added to validate the value of a tokenID. Tests have been updated accordingly.
Implement attestation validator
|
🎉 This PR is included in version 2.5.0-beta.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
exports utils for identifying hypercert tokenID and getting the claimId from a fraction ID
Token ID utils
|
🎉 This PR is included in version 2.5.0-beta.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Expors validator factory to expose the custom validator classes
fix(exports): export validator factory
|
🎉 This PR is included in version 2.5.0-beta.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Releases updated validation methods and support for geoJSON in properties