Skip to content

Configure resources of the hyperdx-deployment initContainers #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Configure resources of the hyperdx-deployment initContainers #124

wants to merge 5 commits into from

Conversation

JaspreetSandhu
Copy link

Update the chart template to configure resources in the hyperdx-deployment initContainers section.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 24, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 22093cd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@JaspreetSandhu JaspreetSandhu changed the title Configure resources inof the hyperdx-deployment initContainers Configure resources of the hyperdx-deployment initContainers Sep 24, 2025
@JaspreetSandhu JaspreetSandhu force-pushed the jaspreetsandhu/hyperdx-deployment/config-initContainer-resources branch from ab687be to c70def3 Compare September 24, 2025 19:57
@JaspreetSandhu JaspreetSandhu marked this pull request as ready for review September 24, 2025 19:58
@JaspreetSandhu
Copy link
Author

@dhable would you mind reviewing please?

dhable
dhable requested changes Sep 26, 2025
View reviewed changes
charts/hdx-oss-v2/templates/hyperdx-deployment.yaml Outdated
- name: wait-for-mongodb
image: busybox
command: ['sh', '-c', 'until nc -z {{ include "hdx-oss.fullname" . }}-mongodb {{ .Values.mongodb.port }}; do echo waiting for mongodb; sleep 2; done;']
{{- if .Values.hyperdx.initContainers.resources }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were a lot of test failures from this PR. It's stemming from this line when an initContainer isn't defined. The target of the resources property lookup is null and this crashes.

There is a function called dig that can provide safe access to nested properties while handling null values safely.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you -- opted for hasKey for simplicity, and since there's no meaningful default value that I need if key isn't present. WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhable dhable dhable requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JaspreetSandhu @dhable