Skip to content
Open
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions examples/hello-node-express/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ const { context, metrics, propagation, trace } = require('@opentelemetry/api');

initSDK({
// advancedNetworkCapture: true,
networkBodyCapture: false,
networkHeadersCapture: false,
// betaMode: true,
// consoleCapture: true,
});
Expand Down
7 changes: 7 additions & 0 deletions packages/node-opentelemetry/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,13 @@ This can be accomplished by setting `HDX_NODE_ADVANCED_NETWORK_CAPTURE` environm
export HDX_NODE_ADVANCED_NETWORK_CAPTURE=1
```

If you only want to capture the header or body, we also provide two separate flags for you.

```sh
export HDX_NODE_NETWORK_HEADERS_CAPTURE=1
export HDX_NODE_NETWORK_BODY_CAPTURE=1
```

By default, all request/response headers will be captured. You can specify a custom list of headers to capture
by setting `OTEL_INSTRUMENTATION_HTTP_CAPTURE_HEADERS_CLIENT_REQUEST`,
`OTEL_INSTRUMENTATION_HTTP_CAPTURE_HEADERS_CLIENT_RESPONSE`,
Expand Down
51 changes: 51 additions & 0 deletions packages/node-opentelemetry/__tests__/packageJsonComp.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
import { comparePackageVersions } from '../utils/comparison';

describe('comparePackageJsonVersions', () => {
test('equal versions return true for ==', () => {
expect(comparePackageVersions('1.0.0', '==', '1.0.0')).toBe(true);
});

test('different versions return false for ==', () => {
expect(comparePackageVersions('1.0.0', '==', '1.0.1')).toBe(false);
});

test('higher version returns true for >', () => {
expect(comparePackageVersions('1.0.1', '>', '1.0.0')).toBe(true);
});

test('lower version returns false for >', () => {
expect(comparePackageVersions('1.0.0', '>', '1.0.1')).toBe(false);
});

test('higher version returns true for >= when versions are equal', () => {
expect(comparePackageVersions('1.0.0', '>=', '1.0.0')).toBe(true);
});

test('higher version returns true for >=', () => {
expect(comparePackageVersions('1.0.1', '>=', '1.0.0')).toBe(true);
});

test('lower version returns false for >=', () => {
expect(comparePackageVersions('1.0.0', '>=', '1.0.1')).toBe(false);
});

test('lower version returns true for <', () => {
expect(comparePackageVersions('1.0.0', '<', '1.0.1')).toBe(true);
});

test('higher version returns false for <', () => {
expect(comparePackageVersions('1.0.1', '<', '1.0.0')).toBe(false);
});

test('lower version returns true for <= when versions are equal', () => {
expect(comparePackageVersions('1.0.0', '<=', '1.0.0')).toBe(true);
});

test('lower version returns true for <=', () => {
expect(comparePackageVersions('1.0.0', '<=', '1.0.1')).toBe(true);
});

test('higher version returns false for <=', () => {
expect(comparePackageVersions('1.0.1', '<=', '1.0.0')).toBe(false);
});
});
Loading