chore: Add playwright tests for app in local-only mode #1181

teeohhem · 2025-09-18T17:10:04Z

Fixes: HDX-2442

vercel · 2025-09-18T17:10:09Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
hyperdx-v2-oss-app	Ready	Preview	Comment	Sep 20, 2025 1:42am

changeset-bot · 2025-09-18T17:10:09Z

⚠️ No Changeset found

Latest commit: 14a208b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2025-09-18T18:23:24Z

🎭 Playwright Test Results

**Tests:** 23
**✅ Passed:** 11
**❌ Failed:** 6
**⚠️ Flaky:** 4
**⏭️ Skipped:** 2
**⏱️ Duration:** 249s

❌ Some tests failed. Check the [Playwright report](https://github.com/hyperdxio/hyperdx/actions/runs/17837678743) for details.

github-actions · 2025-09-18T18:42:38Z

🎭 Playwright Test Results

**Tests:** 23
**✅ Passed:** 12
**❌ Failed:** 4
**⚠️ Flaky:** 4
**⏭️ Skipped:** 3
**⏱️ Duration:** 213s

❌ Some tests failed. Check the [Playwright report](https://github.com/hyperdxio/hyperdx/actions/runs/17838142368) for details.

github-actions · 2025-09-18T19:04:45Z

🎭 Playwright Test Results

**Tests:** 23
**✅ Passed:** 18
**❌ Failed:** 0
**⚠️ Flaky:** 2
**⏭️ Skipped:** 3
**⏱️ Duration:** 170s

✅ All tests passed!

github-actions · 2025-09-19T13:27:49Z

🎭 Playwright Test Results

**Tests:** 21
**✅ Passed:** 16
**❌ Failed:** 0
**⚠️ Flaky:** 2
**⏭️ Skipped:** 3
**⏱️ Duration:** 161s

✅ All tests passed!

github-actions · 2025-09-19T14:04:14Z

E2E Test Results

✅ **All tests passed** • 14 passed • 3 skipped • 146s

teeohhem · 2025-09-19T14:38:16Z

packages/app/tests/e2e/features/search/saved-search.spec.ts

+      ).toBeVisible();
+    },
+  );
+});


will enable after we create a docker image in a future ticket

teeohhem · 2025-09-19T14:38:49Z

packages/app/tests/e2e/features/alerts.spec.ts

+      await expect(page.locator('[data-testid="alerts-modal"]')).toBeVisible();
+    });
+  });
+});


tests are running in local-only mode. Will re-enable once we have a docker image with full server in a future ticket

teeohhem · 2025-09-19T14:39:41Z

packages/app/playwright.config.ts

+  /* Retry on CI only */
+  retries: process.env.CI ? 2 : 1,
+  /* Use multiple workers on CI for faster execution */
+  workers: undefined,


allows playwright to use as many cores that are available

teeohhem · 2025-09-19T14:40:00Z

packages/app/playwright.config.ts

+      use: {
+        ...devices['Desktop Chrome'],
+      },
+    },


can add more browsers later

teeohhem · 2025-09-19T14:40:14Z

packages/app/playwright.config.ts

+    timeout: 180 * 1000,
+    stdout: 'pipe',
+    stderr: 'pipe',
+  },


run server in local-only mode for simplicty

github-actions · 2025-09-19T14:51:05Z

E2E Test Results

✅ **All tests passed** • 14 passed • 3 skipped • 127s

github-actions · 2025-09-19T14:57:12Z

E2E Test Results

✅ **All tests passed** • 14 passed • 3 skipped • 129s

- Add Playwright configuration and GitHub Actions workflow - Implement test utilities and base test setup - Add E2E tests for core navigation functionality - Add comprehensive search feature tests (filters, saved searches) - Add dashboard, alerts, and chart explorer tests - Add session and trace workflow tests - Add source management tests - Update CI/CD pipeline to include E2E testing - Improve test data attributes and component accessibility cleanup and test flakiness fix workflow name update

github-actions · 2025-09-19T15:26:16Z

E2E Test Results

✅ **All tests passed** • 14 passed • 3 skipped • 133s

<details>
<summary>View Details</summary>

| Status | Count |
|--------|-------|
| ✅ Passed | 14 |
| ❌ Failed | 0 |
| ⚠️ Flaky | 2 |
| ⏭️ Skipped | 3 |

</details>

[View full report →](https://github.com/hyperdxio/hyperdx/actions/runs/17862571105)

github-actions · 2025-09-19T15:33:18Z

E2E Test Results

✅ **All tests passed** • 14 passed • 3 skipped • 128s

| Status | Count |
|--------|-------|
| ✅ Passed | 14 |
| ❌ Failed | 0 |
| ⚠️ Flaky | 2 |
| ⏭️ Skipped | 3 |

[View full report →](https://github.com/hyperdxio/hyperdx/actions/runs/17862753669)

github-actions · 2025-09-19T16:08:04Z

E2E Test Results

❌ 1 test failed • 15 passed • 3 skipped • 124s

Status	Count
✅ Passed	15
❌ Failed	1
⚠️ Flaky	0
⏭️ Skipped	3

View full report →

linting Cleanup unused code linting better report commenting install job deps increase timeout and adjust README Update README.md

teeohhem · 2025-09-19T16:24:14Z

packages/api/src/routers/external-api/v2/index.ts

-const rateLimiterKeyGenerator = (req: express.Request) => {
-  return req.headers.authorization || req.ip;
+const rateLimiterKeyGenerator = (req: express.Request): string => {
+  return req.headers.authorization ?? req.ip ?? 'unknown';


linting failure fix

knudtty

no comments - this is great!

pulpdrew · 2025-09-19T18:53:46Z

packages/app/tests/e2e/README.md

@@ -0,0 +1,190 @@
+# End-to-End Testing


Nice README!

nit: It could be nice to have a small section in the CONTRIBUTING.md's testing section that points contributors to this document

pulpdrew · 2025-09-19T18:56:32Z

packages/app/tests/e2e/README.md

+- Node.js (>=22.16.0 as specified in package.json)
+- Dependencies installed via `yarn install`
+- Development server running (automatically handled by test configuration)


This extra step seemed to be required for me

Suggested change

- Node.js (>=22.16.0 as specified in package.json)

- Dependencies installed via `yarn install`

- Development server running (automatically handled by test configuration)

- Node.js (>=22.16.0 as specified in package.json)

- Dependencies installed via `yarn install`

- Playwright installed via `yarn playwright install` in the `packages/app` directory

- Development server running (automatically handled by test configuration)

teeohhem · 2025-09-20T01:39:10Z

@pulpdrew / @knudtty Thanks for the feedback! I'll create follow-up tickets for the readme improvements.

vercel bot had a problem deploying to Preview September 18, 2025 17:40 Failure

vercel bot had a problem deploying to Preview September 18, 2025 17:56 Failure

vercel bot had a problem deploying to Preview September 18, 2025 18:05 Failure

vercel bot had a problem deploying to Preview September 18, 2025 18:09 Failure

vercel bot had a problem deploying to Preview September 18, 2025 18:18 Failure

vercel bot had a problem deploying to Preview September 18, 2025 18:38 Failure

vercel bot had a problem deploying to Preview September 18, 2025 19:01 Failure

vercel bot deployed to Preview September 19, 2025 13:14 View deployment

vercel bot deployed to Preview September 19, 2025 13:25 View deployment

vercel bot deployed to Preview September 19, 2025 13:34 View deployment

vercel bot deployed to Preview September 19, 2025 14:04 View deployment

teeohhem force-pushed the tom/add-e2e-tests branch from c996183 to ac8fd09 Compare September 19, 2025 14:37

teeohhem marked this pull request as ready for review September 19, 2025 14:37

teeohhem commented Sep 19, 2025

View reviewed changes

packages/app/playwright.config.ts

use: {

...devices['Desktop Chrome'],

},

},

Copy link

Contributor Author

teeohhem Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can add more browsers later

vercel bot deployed to Preview September 19, 2025 14:40 View deployment

teeohhem commented Sep 19, 2025

View reviewed changes

hyperdxio deleted a comment from github-actions bot Sep 19, 2025

vercel bot deployed to Preview September 19, 2025 14:55 View deployment

teeohhem requested a review from knudtty September 19, 2025 15:02

teeohhem added 2 commits September 19, 2025 11:19

Merge remote-tracking branch 'origin/main' into tom/add-e2e-tests

09d08cb

teeohhem force-pushed the tom/add-e2e-tests branch from 71b361a to 09d08cb Compare September 19, 2025 15:22

vercel bot deployed to Preview September 19, 2025 15:24 View deployment

vercel bot deployed to Preview September 19, 2025 15:31 View deployment

teeohhem force-pushed the tom/add-e2e-tests branch from cc91460 to 8122ad5 Compare September 19, 2025 15:43

vercel bot deployed to Preview September 19, 2025 15:48 View deployment

vercel bot deployed to Preview September 19, 2025 15:55 View deployment

teeohhem force-pushed the tom/add-e2e-tests branch from 739905a to cdcaa00 Compare September 19, 2025 16:03

vercel bot deployed to Preview September 19, 2025 16:11 View deployment

linting and job tweaks

1065378

linting Cleanup unused code linting better report commenting install job deps increase timeout and adjust README Update README.md

teeohhem force-pushed the tom/add-e2e-tests branch from cdcaa00 to 1065378 Compare September 19, 2025 16:14

vercel bot deployed to Preview September 19, 2025 16:17 View deployment

teeohhem commented Sep 19, 2025

View reviewed changes

teeohhem requested a review from pulpdrew September 19, 2025 16:25

knudtty approved these changes Sep 19, 2025

View reviewed changes

pulpdrew reviewed Sep 19, 2025

View reviewed changes

teeohhem added the automerge label Sep 20, 2025

Merge branch 'main' into tom/add-e2e-tests

14a208b

vercel bot deployed to Preview September 20, 2025 01:42 View deployment

kodiakhq bot merged commit 83b9c8a into main Sep 20, 2025
7 of 8 checks passed

kodiakhq bot deleted the tom/add-e2e-tests branch September 20, 2025 01:43

chore: Add playwright tests for app in local-only mode #1181

chore: Add playwright tests for app in local-only mode #1181

Uh oh!

Conversation

teeohhem commented Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel bot commented Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

github-actions bot commented Sep 18, 2025

🎭 Playwright Test Results

Uh oh!

github-actions bot commented Sep 18, 2025

🎭 Playwright Test Results

Uh oh!

github-actions bot commented Sep 18, 2025

🎭 Playwright Test Results

Uh oh!

github-actions bot commented Sep 19, 2025

🎭 Playwright Test Results

Uh oh!

github-actions bot commented Sep 19, 2025

E2E Test Results

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Sep 19, 2025

E2E Test Results

Uh oh!

github-actions bot commented Sep 19, 2025

E2E Test Results

Uh oh!

github-actions bot commented Sep 19, 2025

E2E Test Results

Uh oh!

github-actions bot commented Sep 19, 2025

E2E Test Results

Uh oh!

github-actions bot commented Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

E2E Test Results

Uh oh!

Choose a reason for hiding this comment

Uh oh!

knudtty left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

teeohhem commented Sep 20, 2025

Uh oh!

Uh oh!

Uh oh!

teeohhem commented Sep 18, 2025 •

edited

Loading

vercel bot commented Sep 18, 2025 •

edited

Loading

changeset-bot bot commented Sep 18, 2025 •

edited

Loading

github-actions bot commented Sep 19, 2025 •

edited

Loading