Skip to content

Conversation

teeohhem
Copy link
Contributor

This reverts commit d60d920.

Commit breaks dashboards with:
image

Copy link

vercel bot commented Sep 20, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
hyperdx-v2-oss-app Building Building Preview Comment Sep 20, 2025 2:08am

Copy link

changeset-bot bot commented Sep 20, 2025

⚠️ No Changeset found

Latest commit: 39b09d4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

E2E Test Results

All tests passed • 16 passed • 3 skipped • 123s

Status Count
✅ Passed 16
❌ Failed 0
⚠️ Flaky 0
⏭️ Skipped 3

View full report →

Copy link
Contributor

@MikeShi42 MikeShi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we didn't check tableConnections length is my assumption, but that logic probably needs a bit more beefing up for other cases.

On further inspection there's a few other areas to improve upon as well, such as the lack of connectionId in the useJsonColumns query key (more of an edge case). (unrelated to original PR but just noticed as reviewing)

@kodiakhq kodiakhq bot merged commit 68f46e0 into main Sep 20, 2025
7 of 8 checks passed
@kodiakhq kodiakhq bot deleted the tom/revert-json-autocomplete branch September 20, 2025 02:18
kodiakhq bot pushed a commit that referenced this pull request Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants