-
Notifications
You must be signed in to change notification settings - Fork 319
feat: Include displayed timestamp in default order by #1279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 7445bbf The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for GitHub.
💡 Enable Vercel Agent with $100 free credit for automated AI reviews |
placeholder="SpanName" | ||
/> | ||
</FormRow> | ||
<FormRow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This field was already being inferred for the default OTEL trace table, now we allow the user to modify it if needed.
PR Review✅ No critical issues found. Code Quality Notes:The implementation looks solid. The logic correctly:
Minor observations (non-blocking):
The changeset and documentation updates are appropriate for this feature. |
E2E Test Results✅ All tests passed • 26 passed • 3 skipped • 249s
|
3e718c9
to
383704b
Compare
383704b
to
7445bbf
Compare
Maybe its a bug maybe not,but the timestamp column gets changed when sorting Screen.Recording.2025-10-17.at.3.39.37.PM.mov |
That's a good point. Though it seems that the default order by is restored if the user clicks on the table header again to unsort by the column. And this is existing behavior whenever the default order by is not the I think the solution would be to determine if the user is clicking on a timestamp-type column which is included in the default order by, and in that case override the selected sort column with the default optimized order by. That could be a good enhancement. |
Closes HDX-2593
This PR adds a source's
displayedTimestampValueExpression
(if one exists) to the default order by on the search page.In schemas like our default otel_logs table, there are two timestamp columns:
TimestampTime DateTime
(1-second precision) and aTimestamp DateTime64(9)
(nanosecond precision).TimestampTime
is preferred for filtering because it is more granular and in the primary key. However, ordering byTimestampTime
alone results in an arbitrary order of events within each second:The HyperDX source configuration form already supports configuring a 'Displayed Timestamp Column" for a log source. This PR adds the same option for Trace sources. This field is inferred from the otel logs and traces schemas as
Timestamp
.If the source has a displayed timestamp column configured, and if this column is different than the source's timestamp value expression, then this field will be added to the default order by which is generated for the search page. This results in a more precise ordering of the events in the logs table within each second: