Skip to content

Conversation

wrn14897
Copy link
Member

This PR reverts #937

Ref: HDX-2620

Copy link

changeset-bot bot commented Oct 17, 2025

🦋 Changeset detected

Latest commit: a785e6e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@hyperdx/api Patch
@hyperdx/app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Oct 17, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
hyperdx-v2-oss-app Ready Ready Preview Comment Oct 17, 2025 8:56pm

💡 Enable Vercel Agent with $100 free credit for automated AI reviews

Copy link

claude bot commented Oct 17, 2025

PR Review: Revert API esbuild

This PR reverts the esbuild bundling for the API package (PR #937) and returns to the standard TypeScript compilation approach.

Review

No critical issues found.

The revert is cleanly implemented and addresses the bundling approach:

Changes verified:

  • ✅ Build process reverted from esbuild bundling to standard tsc + tsc-alias
  • ✅ Dockerfile correctly updated to copy build/ dir instead of dist/
  • ✅ Proto file path simplified in protobuf.ts (removed IS_PROD conditional)
  • ✅ Entry scripts updated to reference correct paths
  • ✅ TypeScript config properly restored with standard settings
  • ✅ Production dependencies properly installed via yarn workspaces focus

Minor observations (non-blocking):

  • The revert increases Docker image size (~300MB) but restores simpler build process
  • All path references appear consistent with new build structure
  • Changeset properly documented

Recommendation: ✅ Approved for merge

Copy link
Contributor

github-actions bot commented Oct 17, 2025

E2E Test Results

All tests passed • 26 passed • 3 skipped • 240s

Status Count
✅ Passed 26
❌ Failed 0
⚠️ Flaky 0
⏭️ Skipped 3

View full report →

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant