Skip to content

Ensure correct query timeout value is used. #1417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 8 commits into from
Dec 2, 2025
Merged

Ensure correct query timeout value is used. #1417

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
75ce009
Ensure correct query timeout value is used. For example, it defaults…
brandon-pereira Nov 28, 2025
049e08a
add changeset
brandon-pereira Nov 28, 2025
c688277
tweak test value
brandon-pereira Nov 28, 2025
764d716
use built in query timeout logic instead of setTimeout
brandon-pereira Dec 1, 2025
603f1b7
Merge branch 'main' into feature/fix-query-timeout-setting
brandon-pereira Dec 1, 2025
aaa7d4d
add a user defined timeout
brandon-pereira Dec 1, 2025
bc12a46
tweak copy of todo
brandon-pereira Dec 2, 2025
e0f6446
Merge branch 'main' into feature/fix-query-timeout-setting
kodiakhq[bot] Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/giant-ways-taste.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@hyperdx/app": patch
---

fix issue with query timeout on the search page
2 changes: 1 addition & 1 deletion packages/app/src/hooks/__tests__/useOffsetPaginatedQuery.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jest.mock('@/api', () => ({
useMe: () => ({
data: {
team: {
queryTimeout: 30000,
queryTimeout: 30,
},
},
}),
Expand Down
5 changes: 3 additions & 2 deletions packages/app/src/hooks/useOffsetPaginatedQuery.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,12 +165,13 @@ const queryFn: QueryFunction<TQueryFnData, TQueryKey, TPageParam> = async ({
const query = await renderChartConfig(windowedConfig, getMetadata());

const queryTimeout = queryKey[2];
const clickhouseClient = getClickhouseClient();
// TODO: it seems like queryTimeout is not being honored, we should fix this
const clickhouseClient = getClickhouseClient({ queryTimeout });
Copy link
Member Author

@brandon-pereira brandon-pereira Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this here, doesn't hurt to pass it


// Create abort signal from timeout if provided
const abortController = queryTimeout ? new AbortController() : undefined;
if (abortController && queryTimeout) {
setTimeout(() => abortController.abort(), queryTimeout);
setTimeout(() => abortController.abort(), queryTimeout * 1000);
}

const resultSet =
Expand Down
Loading