Skip to content

Conversation

@brandon-pereira
Copy link
Member

Adds better support for nested Requested Throughput deeplinking, and adds better support for passing string filters which contain JSON

Before After
Screenshot 2025-12-02 at 10 14 11 AM Screenshot 2025-12-02 at 10 14 41 AM
Screenshot 2025-12-02 at 10 13 52 AM Screenshot 2025-12-02 at 10 13 45 AM

Fixes HDX-2932, HDX-2933

Adds better support for nested Requested Throughput deeplinking, and adds better support for passing string filters which contain JSON

Fixes HDX-2932, HDX-2933
@brandon-pereira brandon-pereira requested review from a team and dhable and removed request for a team December 2, 2025 17:16
@changeset-bot
Copy link

changeset-bot bot commented Dec 2, 2025

🦋 Changeset detected

Latest commit: 1655cb8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@hyperdx/app Patch
@hyperdx/api Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Dec 2, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
hyperdx-v2-oss-app Ready Ready Preview Comment Dec 3, 2025 4:35pm

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

E2E Test Results

All tests passed • 46 passed • 3 skipped • 273s

Status Count
✅ Passed 46
❌ Failed 0
⚠️ Flaky 0
⏭️ Skipped 3

View full report →

@claude
Copy link

claude bot commented Dec 2, 2025

PR Review

🔒 Critical Security Issue:

  • SQL Injection vulnerability in ServiceDashboardEndpointSidePanel.tsx:52,58 → The endpoint and service variables from query params are directly interpolated into SQL conditions without escaping. Single quotes in user input would break the query syntax or allow injection.
    • Fix: Escape single quotes in values (replace ' with '') or use a proper SQL parameterization approach

⚠️ Code Quality Issues:

  • searchFilters.tsx:187 → Using case-sensitive includes('NOT IN') check after case-insensitive .toUpperCase() check is inconsistent
    • Fix: Use .toUpperCase().includes(' NOT IN ') for consistency
  • searchFilters.tsx:190-191 → The split logic will fail if " NOT IN " appears before " IN " in the same string
    • Fix: Check for NOT IN first, or use regex-based splitting

📝 Minor Notes:

  • Test coverage looks comprehensive with good edge case handling
  • The string parsing logic is complex but well-tested
  • Consider adding a comment explaining why OR conditions are skipped (searchFilters.tsx:178)

Co-authored-by: Nathan Perriolat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants