Add clippy to CI #3153
Closed
Add clippy to CI #3153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! I'm still surprised this doesn't catch that there is an |
|
Seems like there are some bugs in the lint: rust-lang/rust-clippy#8094 |
palango
force-pushed
the
clippy
branch
2 times, most recently
from
6560c97 to
bd20988
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds limited clippy run to CI.
There were two clippy warnings which seemed useful, they're in the second commit. If you don't like them I'm happy to drop the commit.
Resolves #2977
Superseeds #2979