Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(common): remove common re-export #3346

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

tottoto
Copy link
Contributor

@tottoto tottoto commented Oct 13, 2023

There have been mix of the way of using these types, both re-exported and direct using. This pull request proposes to use them directly consistently as using re-exported ones consistently seems to be difficult and using them directly seems simple.

@tottoto tottoto force-pushed the remove-common-re-export branch from dbbd13a to 53cff4d Compare October 13, 2023 22:45
@tottoto tottoto changed the title refactor(lib): remove common re-export refactor(common): remove common re-export Oct 13, 2023
@tottoto tottoto force-pushed the remove-common-re-export branch from 53cff4d to 043b4be Compare October 14, 2023 23:45
Copy link
Member

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressive!

@seanmonstar seanmonstar merged commit d9216c3 into hyperium:master Oct 18, 2023
19 checks passed
@tottoto tottoto deleted the remove-common-re-export branch October 18, 2023 11:41
0xE282B0 pushed a commit to 0xE282B0/hyper that referenced this pull request Jan 12, 2024
0xE282B0 pushed a commit to 0xE282B0/hyper that referenced this pull request Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants