Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(common): move compat constructor to method #3367

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

tottoto
Copy link
Contributor

@tottoto tottoto commented Oct 22, 2023

This is a small refactoring. The constructor of Compat has been defined as an independent function, compat. As its name is the same of the module name compat, which the constructor function belongs to, it seems a little bit complicating. Moving it to the method reduces the re-export of the function as well. It might slightly improve readability.

@tottoto tottoto force-pushed the compat-constructor branch from 49164f8 to 0b53c89 Compare October 22, 2023 15:30
@tottoto tottoto force-pushed the compat-constructor branch from 0b53c89 to c51b4d7 Compare October 22, 2023 15:59
@seanmonstar seanmonstar merged commit 54c8670 into hyperium:master Oct 23, 2023
19 checks passed
@tottoto tottoto deleted the compat-constructor branch October 23, 2023 13:43
0xE282B0 pushed a commit to 0xE282B0/hyper that referenced this pull request Jan 12, 2024
0xE282B0 pushed a commit to 0xE282B0/hyper that referenced this pull request Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants