Closes #385: Call EvaluateRuleEntry listeners when rules evaluated in FindMatchingRules #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… evaluated in FindMatchingRules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rules can be evaluated both in the engine's ExecuteWithContext()/Execute() function and inside of FindMatchingRules(), but listeners are only triggered in the Execute() call.
It'd be helpful if notifyEvaluateRuleEntry were added to FindMatchingRules() to trigger EvaluateRuleEntry listeners when FindMatchingRules() is called.
My motivation for this is to be able to get the rule names affected when FindMatchingRules() returns an error during processing of a rule like I'd do with a listener for Evaluate().