Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grule issue #431. update go-git to v5. #435

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

davidsonff
Copy link
Contributor

Update to go-git v5

@laurenfr
Copy link

Thanks for doing this--definitely fairly urgent security-wise, so a timely approval & release from a maintainer would be most appreciated 🙏

@GreyBouton
Copy link

Everything looks good. I just got a call from corporate and we need to ship this asap.

@juburr
Copy link

juburr commented Jan 30, 2024

@newm4n can you assist?

@vamsitadikonda-discovery

Looks like it still needs an approval.

@GreyBouton
Copy link

@newm4n Everything checks out, let's go ahead and merge this. My organization already forked this code to fulfill the dependency but we would like to go back to this one. If we do not get this done, the UN may get involved and we do not want that.

@niallnsec
Copy link
Collaborator

I've been away from the project for a while, but it seems the other maintainers are busy and I have some time at the moment.

I agree this vulnerability is worthy of being considered critical. There don't seem to be any external effects to upgrading the go-git dependency which makes this nice and simple.

LGTM

@niallnsec niallnsec merged commit e4e90fe into hyperjumptech:master Jan 30, 2024
1 check passed
@procommand
Copy link

The codes quality overall deviates from industry norms yet this sort of work is commendable yet also punishable by a probationary period not sure what to say except it is what it is as long as it works right? Duck tape strategy?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants