Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Upgrade Oclif Core to Version 4 #1318

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

haricnugraha
Copy link
Contributor

Monika Pull Request (PR)

What feature/issue does this PR add

Upgrade oclif/core to version 4.

How to test

  1. Run the test. Run npm test.
  2. Run Monika as usual. Run npm start.

@haricnugraha haricnugraha marked this pull request as draft October 4, 2024 09:09
@haricnugraha haricnugraha marked this pull request as ready for review October 7, 2024 03:45
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 41.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 63.32%. Comparing base (6a29470) to head (3f8cc5d).
Report is 26 commits behind head on main.

Files with missing lines Patch % Lines
src/commands/monika.ts 50.00% 1 Missing and 1 partial ⚠️
src/components/config/create.ts 33.33% 2 Missing ⚠️
src/components/logger/flush.ts 33.33% 2 Missing ⚠️
src/plugins/updater/index.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1318      +/-   ##
==========================================
+ Coverage   62.51%   63.32%   +0.80%     
==========================================
  Files         112      109       -3     
  Lines        3391     3422      +31     
  Branches      591      584       -7     
==========================================
+ Hits         2120     2167      +47     
+ Misses       1079     1067      -12     
+ Partials      192      188       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@haricnugraha haricnugraha marked this pull request as draft October 7, 2024 07:26
Copy link
Contributor

@sapiderman sapiderman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woorks for me
🤑 💸 💰

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants