Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/refactor try decode ica body function #69

Conversation

xxxigm
Copy link

@xxxigm xxxigm commented Apr 29, 2024

Here are some suggestions for improvement:

  1. Input Validation: Ensure that the input body is valid before attempting to decode it. It seems like you're checking if it's falsy or if it represents zero in a BigNumber context. However, it might be more robust to explicitly check if it's a string.
  2. Error Handling: Your code is already catching errors during decoding, which is good practice. However, it's important to handle errors appropriately and provide meaningful error messages.
  3. Type Safety: TypeScript provides powerful type checking capabilities. Ensure that you're leveraging them fully to catch potential errors at compile time.

@xxxigm xxxigm requested review from yorhodes and jmrossy as code owners April 29, 2024 03:21
Copy link

vercel bot commented Apr 29, 2024

@NguyenTuanCanh is attempting to deploy a commit to the Abacus Works Team on Vercel.

A member of the Team first needs to authorize it.

@jmrossy
Copy link
Collaborator

jmrossy commented Apr 29, 2024

Thanks @NguyenTuanCanh for the effort here but I don't see any real value in this change. Given that your change also fails to build and fails the formatter check, I don't think we should spend any more time on this. Sorry!

@jmrossy jmrossy closed this Apr 29, 2024
@xxxigm xxxigm deleted the feature/refactor-try-decode-ica-body-function branch April 29, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants