Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infra's checker should use registry-checked-in warp config #5272

Open
nambrot opened this issue Jan 23, 2025 · 1 comment · Fixed by #5344
Open

Infra's checker should use registry-checked-in warp config #5272

nambrot opened this issue Jan 23, 2025 · 1 comment · Fixed by #5344
Assignees
@ltyu
Labels
warp-route

Comments

@nambrot
Copy link
Contributor

nambrot commented Jan 23, 2025

No description provided.

@nambrot nambrot moved this to Sprint in Hyperlane Tasks Jan 23, 2025
@ltyu ltyu moved this from Sprint to In Progress in Hyperlane Tasks Jan 27, 2025
@ltyu ltyu mentioned this issue Jan 30, 2025
Merged
@ltyu ltyu moved this from In Progress to In Review in Hyperlane Tasks Jan 30, 2025
github-merge-queue bot pushed a commit that referenced this issue Jan 31, 2025
@ltyu
feat: replace Getters with Registry Warp Config (#5344)
7641389 
### Description
This PR replaces all non-AW managed Getters with Registry configs

### Related issues
- Fixes #5239
- Fixes #5272

### Backward compatibility
Yes

### Testing
Tested with all
- `yarn tsx ./typescript/infra/scripts/check/check-deploy.ts -e mainnet3
-m warp --warpRouteId WETH/artela-base`
- `yarn tsx ./scripts/warp-routes/generate-warp-config.ts -e mainnet3
--warpRouteId WETH/artela-base`
- `yarn tsx ./typescript/infra/scripts/check/check-warp-deploy.ts -e
mainnet3 -m warp`
- `yarn test:unit`
@github-project-automation github-project-automation bot moved this from In Review to Done in Hyperlane Tasks Jan 31, 2025
@nambrot nambrot reopened this Feb 4, 2025
@github-project-automation github-project-automation bot moved this from Done to Sprint in Hyperlane Tasks Feb 4, 2025
@nambrot
Copy link
Contributor Author

nambrot commented Feb 4, 2025

Re-opening this to have check-deploy specify a registry commit SHA as a command line arg

@ltyu ltyu mentioned this issue Feb 4, 2025
Closed
@nambrot nambrot moved this from Sprint to In Progress in Hyperlane Tasks Feb 4, 2025
@nambrot nambrot moved this from In Progress to In Review in Hyperlane Tasks Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ltyu ltyu

Labels
warp-route
Projects
Hyperlane Tasks
Status: In Review
Milestone
No milestone
2 participants
@nambrot @ltyu