feat: Update infra checker use MergedRegistry #5373
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5373 +/- ##
=======================================
Coverage 77.53% 77.53%
=======================================
Files 103 103
Lines 2110 2110
Branches 190 190
=======================================
Hits 1636 1636
Misses 453 453
Partials 21 21
|
ltyu
requested review from
tkporter,
paulbalaji and
Mo-Hussain
as code owners
| return new GithubRegistry({ | ||
| uri, | ||
| logger: rootLogger.child({ module: 'infra-github-registry' }), | ||
| branch: process.env.REGISTRY_BRANCH || 'main', |
There was a problem hiding this comment.
not really sure if we need this. may remove...
| * and an override one (such as a github directory) | ||
| * @returns a new MergedRegistry | ||
| */ | ||
| export function getMergedRegistry( |
There was a problem hiding this comment.
Could we just import the CLI function here and then call this with primaryRegistryUri from DEFAULT_REGISTRY_URI? Why introduce another ENV var and this logic?
Description
This PR updates the infra warp getter to use a MergeRegistry such that it uses the
DEFAULT_REGISTRY_URIas the FileSystemRegistry and then overrides withREGISTRY_URI. Also adds the option of adding a branch to read from the GithubRegistryRelated issues
Backward compatibility
Yes, the intention of this is to have the same functionality as
getRegistry()of infra registry.ts but with the option of using the GithubRegistryTesting
Manual