Merged
Conversation
paulbalaji
requested review from
Mo-Hussain,
Xaroz,
ameten,
antigremlin,
ltyu,
nambrot,
troykessler,
xeno097,
yjamin and
yorhodes
as code owners
|
paulbalaji
removed request for
Mo-Hussain,
Xaroz,
ameten,
antigremlin,
kamiyaa,
larryob,
ltyu,
nambrot,
troykessler,
xeno097,
yjamin and
yorhodes
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
paulbalaji
force-pushed
the
pbio-cursor/investigate-pnpm-package-manager-migration-2193
branch
from
921a2e0 to
d187014
Compare
Move the requiresKey check before chain resolution in signerMiddleware. This ensures yargs can validate required arguments before the middleware throws assertion errors for missing chains. Non-sign commands like `core check` were failing with "No chains found set in parameters" instead of the expected "Missing required argument: chain" error from yargs. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Replace `pnpm --filter @hyperlane-xyz/cli run` with `pnpm -C typescript/cli run` for consistency with the rest of the codebase. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
paulbalaji
force-pushed
the
pbio-cursor/investigate-pnpm-package-manager-migration-2193
branch
from
d187014 to
22310c6
Compare
…irectory pnpm -C changes the working directory, breaking relative paths. pnpm --filter runs from the monorepo root where paths are valid. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
typescript/cli/src/tests/ethereum/core/core-check.e2e-test.ts (1)
34-39: pnpm CLI invocation looks good; consider reusing shared helper for consistencyAye, this swap to
pnpm --filter @hyperlane-xyz/cli run hyperlane core checkfits the new toolchain just fine for this “missing --chain” error path, and the.nothrow()usage still makes sense for the assertion that follows.Only thing I’d watch is keeping this in step with the rest of the swamp: if other CLI tests now go through a shared helper (like
localTestRunCmdPrefixor similar), it might be worth routing this one through the same path so future changes to the pnpm invocation don’t drift here unnoticed.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
typescript/cli/src/tests/cosmosnative/core/core-check.e2e-test.ts(1 hunks)typescript/cli/src/tests/ethereum/core/core-check.e2e-test.ts(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- typescript/cli/src/tests/cosmosnative/core/core-check.e2e-test.ts
🧰 Additional context used
🧠 Learnings (5)
📓 Common learnings
Learnt from: paulbalaji
Repo: hyperlane-xyz/hyperlane-monorepo PR: 7410
File: solidity/foundry.toml:8-8
Timestamp: 2025-11-25T17:10:33.369Z
Learning: In the hyperlane-xyz/hyperlane-monorepo repository, when using pnpm (instead of Yarn), Foundry's `allow_paths` in solidity/foundry.toml should be set to `["./node_modules"]` rather than `["../node_modules"]` because pnpm's default node_modules structure places dependencies locally in the workspace subdirectory, not requiring access to the parent directory's node_modules.
Learnt from: paulbalaji
Repo: hyperlane-xyz/hyperlane-monorepo PR: 6943
File: rust/main/config/mainnet_config.json:965-965
Timestamp: 2025-08-26T13:46:37.695Z
Learning: In the repository hyperlane-xyz/hyperlane-monorepo, skip reviewing the file rust/main/config/mainnet_config.json in future code reviews as requested by paulbalaji.
Learnt from: paulbalaji
Repo: hyperlane-xyz/hyperlane-monorepo PR: 6943
File: rust/main/config/mainnet_config.json:965-965
Timestamp: 2025-08-26T13:46:37.695Z
Learning: In the repository hyperlane-xyz/hyperlane-monorepo, skip reviewing the file rust/main/config/testnet_config.json in future code reviews as requested by paulbalaji.
Learnt from: CR
Repo: hyperlane-xyz/hyperlane-monorepo PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-24T17:19:38.362Z
Learning: Apply `yarn prettier` for code formatting across all workspaces
📚 Learning: 2025-11-24T17:19:38.362Z
Learnt from: CR
Repo: hyperlane-xyz/hyperlane-monorepo PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-24T17:19:38.362Z
Learning: Run all tests using `yarn test` for unified testing; use workspace-specific commands for targeted testing (Hardhat, Forge for Solidity; Unit tests for TypeScript; Cargo for Rust)
Applied to files:
typescript/cli/src/tests/ethereum/core/core-check.e2e-test.ts
📚 Learning: 2025-11-25T17:10:33.369Z
Learnt from: paulbalaji
Repo: hyperlane-xyz/hyperlane-monorepo PR: 7410
File: solidity/foundry.toml:8-8
Timestamp: 2025-11-25T17:10:33.369Z
Learning: In the hyperlane-xyz/hyperlane-monorepo repository, when using pnpm (instead of Yarn), Foundry's `allow_paths` in solidity/foundry.toml should be set to `["./node_modules"]` rather than `["../node_modules"]` because pnpm's default node_modules structure places dependencies locally in the workspace subdirectory, not requiring access to the parent directory's node_modules.
Applied to files:
typescript/cli/src/tests/ethereum/core/core-check.e2e-test.ts
📚 Learning: 2025-08-26T13:45:52.227Z
Learnt from: paulbalaji
Repo: hyperlane-xyz/hyperlane-monorepo PR: 6943
File: rust/main/config/testnet_config.json:34-35
Timestamp: 2025-08-26T13:45:52.227Z
Learning: Skip reviewing mainnet_config.json and testnet_config.json configuration files in typescript/infra/config/ and rust/main/config/ directories as requested by paulbalaji to reduce review noise.
Applied to files:
typescript/cli/src/tests/ethereum/core/core-check.e2e-test.ts
📚 Learning: 2025-08-26T13:46:37.695Z
Learnt from: paulbalaji
Repo: hyperlane-xyz/hyperlane-monorepo PR: 6943
File: rust/main/config/mainnet_config.json:965-965
Timestamp: 2025-08-26T13:46:37.695Z
Learning: In the repository hyperlane-xyz/hyperlane-monorepo, skip reviewing the file rust/main/config/testnet_config.json in future code reviews as requested by paulbalaji.
Applied to files:
typescript/cli/src/tests/ethereum/core/core-check.e2e-test.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (72)
- GitHub Check: coverage-run
- GitHub Check: cli-evm-e2e-matrix (warp-check-3)
- GitHub Check: cli-evm-e2e-matrix (warp-check-4)
- GitHub Check: cli-evm-e2e-matrix (warp-init)
- GitHub Check: cli-evm-e2e-matrix (core-check)
- GitHub Check: cli-evm-e2e-matrix (warp-check-2)
- GitHub Check: cli-evm-e2e-matrix (warp-rebalancer)
- GitHub Check: cli-evm-e2e-matrix (core-read)
- GitHub Check: cli-evm-e2e-matrix (warp-deploy-2)
- GitHub Check: cli-evm-e2e-matrix (warp-check-1)
- GitHub Check: cli-evm-e2e-matrix (warp-extend-recovery)
- GitHub Check: cli-evm-e2e-matrix (warp-read)
- GitHub Check: cli-evm-e2e-matrix (warp-send)
- GitHub Check: cli-evm-e2e-matrix (warp-check-5)
- GitHub Check: cli-evm-e2e-matrix (warp-deploy-1)
- GitHub Check: cli-evm-e2e-matrix (relay)
- GitHub Check: cli-evm-e2e-matrix (warp-bridge-1)
- GitHub Check: cli-evm-e2e-matrix (warp-extend-config)
- GitHub Check: cli-evm-e2e-matrix (warp-bridge-2)
- GitHub Check: cli-evm-e2e-matrix (core-deploy)
- GitHub Check: cli-evm-e2e-matrix (warp-apply-ownership-updates)
- GitHub Check: cli-evm-e2e-matrix (warp-apply-submitters)
- GitHub Check: cli-evm-e2e-matrix (warp-extend-basic)
- GitHub Check: cli-evm-e2e-matrix (core-apply)
- GitHub Check: cli-evm-e2e-matrix (warp-apply-simple-updates)
- GitHub Check: cli-evm-e2e-matrix (core-init)
- GitHub Check: cli-evm-e2e-matrix (warp-apply-ism-updates)
- GitHub Check: cli-evm-e2e-matrix (warp-apply-rebalancing-config)
- GitHub Check: cli-evm-e2e-matrix (warp-apply-hook-updates)
- GitHub Check: env-test-matrix (mainnet3, ethereum, igp)
- GitHub Check: env-test-matrix (testnet4, sepolia, core)
- GitHub Check: env-test-matrix (mainnet3, optimism, igp)
- GitHub Check: env-test-matrix (mainnet3, optimism, core)
- GitHub Check: env-test-matrix (mainnet3, ethereum, core)
- GitHub Check: env-test-matrix (mainnet3, arbitrum, core)
- GitHub Check: env-test-matrix (mainnet3, arbitrum, igp)
- GitHub Check: cli-radix-e2e-matrix (warp-apply-ownership-updates)
- GitHub Check: cli-radix-e2e-matrix (warp-deploy)
- GitHub Check: cli-radix-e2e-matrix (core-deploy)
- GitHub Check: cli-cosmos-e2e-matrix (warp-read)
- GitHub Check: cli-radix-e2e-matrix (core-apply)
- GitHub Check: cli-radix-e2e-matrix (warp-apply-route-extension)
- GitHub Check: cli-cosmos-e2e-matrix (warp-deploy)
- GitHub Check: aleo-sdk-e2e-run
- GitHub Check: cli-cosmos-e2e-matrix (core-apply)
- GitHub Check: cli-cosmos-e2e-matrix (core-read)
- GitHub Check: cli-cosmos-e2e-matrix (core-deploy)
- GitHub Check: cli-cosmos-e2e-matrix (core-check)
- GitHub Check: cli-cross-chain-e2e-matrix (warp-deploy)
- GitHub Check: cosmos-sdk-e2e-run
- GitHub Check: cli-install-test-run
- GitHub Check: cli-cross-chain-e2e-matrix (warp-apply)
- GitHub Check: pnpm-test-run
- GitHub Check: infra-test
- GitHub Check: e2e-matrix (starknet)
- GitHub Check: e2e-matrix (sealevel)
- GitHub Check: e2e-matrix (cosmwasm)
- GitHub Check: pnpm-install
- GitHub Check: e2e-matrix (evm)
- GitHub Check: e2e-matrix (radix)
- GitHub Check: e2e-matrix (cosmosnative)
- GitHub Check: agent-configs (mainnet3)
- GitHub Check: agent-configs (testnet4)
- GitHub Check: lint-prettier
- GitHub Check: build-and-push-to-gcr
- GitHub Check: fork-tests
- GitHub Check: slither
- GitHub Check: diff-check
- GitHub Check: test-rs
- GitHub Check: lander-coverage
- GitHub Check: lint-rs
- GitHub Check: diff-check
…upport The previous fix moved the requiresKey check too early, before AltVM providers were set up. This broke non-sign commands (like 'core read') that still need AltVM providers but don't need signers. The check now correctly returns early AFTER setting up AltVM providers but BEFORE signer setup, matching the original behavior.
The test iterates over ~133 warp IDs, each making a network request to the GitHub registry. The default 2000ms timeout was insufficient, causing consistent CI failures.
Collaborator
Author
|
this diff is probably easier to review for the last 6 commits fixing CI |
…te-pnpm-package-manager-migration-2193
paulbalaji
force-pushed
the
pbio-cursor/investigate-pnpm-package-manager-migration-2193
branch
from
96a5f05 to
12f6846
Compare
antigremlin
approved these changes
Dec 12, 2025
Contributor
antigremlin
left a comment
antigremlin
left a comment
There was a problem hiding this comment.
It's getting better all the time
The build:zk script exists in solidity/package.json but was being called from root in npm-beta-release.yml workflow. With pnpm, root scripts don't automatically find workspace scripts. - Add build:zk to turbo.json tasks (depends on build) - Add build:zk script to root package.json delegating to turbo 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
🐳 Monorepo Docker Image Built SuccessfullyImage Tags: |
Contributor
🦀 Rust Agent Docker Image Built SuccessfullyImage Tags: |
2 tasks
github-merge-queue bot
pushed a commit
to hyperlane-xyz/hyperlane-warp-ui-template
that referenced
this pull request
Dec 15, 2025
## Summary Migrate package manager from Yarn 4.x (Berry) to pnpm 10.x, following the patterns established in the monorepo migration ([hyperlane-monorepo#7410](hyperlane-xyz/hyperlane-monorepo#7410)). **Changes:** - Update `packageManager` to pnpm@10.25.0 - Convert `resolutions` to `pnpm.overrides` - Convert yarn patches to `pnpm.patchedDependencies` format - Pin dependency versions to match yarn.lock (pnpm re-resolves `^` ranges to latest): - `@cosmos-kit/react`: 2.18.0 - `@solana/wallet-adapter-wallets`: 0.19.16 - `@rainbow-me/rainbowkit`: 2.2.0 - Add phantom dependencies required by pnpm strict dependency isolation - Update CI workflows to use pnpm (pnpm/action-setup@v4, pnpm store caching) - Update GitHub Actions to latest versions (checkout@v6, setup-node@v6) - Update vercel.json to use pnpm@10.25.0 - Update README with pnpm commands - Remove yarn files (.yarn/, .yarnrc.yml, yarn.lock) - Add pnpm-lock.yaml ## Test plan - [x] `pnpm install` succeeds - [x] `pnpm typecheck` passes - [x] `pnpm build` succeeds - [x] `pnpm lint` passes - [x] CI workflows pass 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Added support for Solana wallet integrations, Sentry error monitoring, and additional Chakra UI packages. * **Chores** * Migrated project tooling, package manager metadata, and CI workflows from Yarn to pnpm; updated GitHub Actions and dev tooling versions. * Upgraded and added multiple dependencies and devDependencies; replaced resolution/patch approach with pnpm-compatible overrides. * **Documentation** * Updated CLI/README commands and ignore lists to reflect pnpm usage. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
paulbalaji
deleted the
pbio-cursor/investigate-pnpm-package-manager-migration-2193
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrate package manager from Yarn 4.x (Berry) to pnpm 10.x.
Design docs:
Changes:
packageManagerto pnpm@10.25.0pnpm-workspace.yamlfor workspace configurationresolutionstopnpm.overridespnpm.patchedDependenciesformat.github/actions/pnpm-cacheaction for CI cachingDrive-by changes
Related issues
Backward compatibility
Yes - no runtime changes, only build tooling migration.
Testing
pnpm installsucceedspnpm buildsucceedspnpm testpassespnpm lintpassesSummary by CodeRabbit
New Features
Chores
✏️ Tip: You can customize this high-level summary in your review settings.