Skip to content

fix(ci): only run bytecode check on PRs targeting main #7802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
larryob wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −0
Open

fix(ci): only run bytecode check on PRs targeting main #7802

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
678b765
ci: only run bytecode check on PRs targeting main
larryob Jan 15, 2026
ffcc5f6
fix(solidity): add bytecode_hash to ci profile for valid compiler config
larryob Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/bytecode-analysis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ name: Check Bytecode Changes

on:
pull_request:
branches:
- main
Comment on lines +5 to +6
Copy link
Collaborator

@paulbalaji paulbalaji Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would we not want to do this for audit branch PRs?

Comment on lines 4 to +6
Copy link
Member

@yorhodes yorhodes Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we do want this to run on all branches following #7801

paths:
- 'solidity/**'
- '.github/workflows/bytecode-analysis.yml'
Expand Down
1 change: 1 addition & 0 deletions solidity/foundry.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ ignored_warnings_from = ['lib', 'test', 'contracts/test']
verbosity = 4
# disable metadata for bytecode comparison
cbor_metadata = false
bytecode_hash = "none"

[rpc_endpoints]
mainnet = "${RPC_URL_MAINNET}"
Expand Down
Loading