Skip to content

test: bytecode change (SHOULD FAIL CI) #7803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
larryob wants to merge 4 commits into
base: main
Choose a base branch
from
+6 −0
Open

test: bytecode change (SHOULD FAIL CI) #7803

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
678b765
ci: only run bytecode check on PRs targeting main
larryob Jan 15, 2026
5fcb9ae
test: add constant to test bytecode check CI
larryob Jan 15, 2026
ffcc5f6
fix(solidity): add bytecode_hash to ci profile for valid compiler config
larryob Jan 15, 2026
3c772a8
Merge fix-bytecode-filter into test-bytecode-change
larryob Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/bytecode-analysis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ name: Check Bytecode Changes

on:
pull_request:
branches:
- main
paths:
- 'solidity/**'
- '.github/workflows/bytecode-analysis.yml'
Expand Down
3 changes: 3 additions & 0 deletions solidity/contracts/Mailbox.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,9 @@ contract Mailbox is

// ============ Constants ============

// Test constant for bytecode check CI test - DELETE ME
uint256 public constant TEST_BYTECODE_CHANGE = 12345;

Comment on lines +34 to +36
Copy link
Contributor

@coderabbitai coderabbitai bot Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

This test constant shouldn't make it into the swamp — er, main branch.

The comment says "DELETE ME" and the PR description confirms this is purely for testin' the bytecode check CI. Once you've verified the workflow fails as expected, this whole thing needs to go. Leavin' test artifacts in a production contract is like leavin' donkeys in places they don't belong.

Make sure to delete the PR and branch after the test, as noted in the objectives.

🤖 Prompt for AI Agents 
In `@solidity/contracts/Mailbox.sol` around lines 34 - 36, Remove the temporary
test constant and its "DELETE ME" comment: delete the uint256 public constant
TEST_BYTECODE_CHANGE = 12345; declaration from Mailbox.sol and ensure there are
no remaining references to TEST_BYTECODE_CHANGE elsewhere (ABI/other
contracts/tests); commit the change and clean up the test PR/branch as described
in the PR notes.

// Domain of chain on which the contract is deployed
uint32 public immutable localDomain;

Expand Down
1 change: 1 addition & 0 deletions solidity/foundry.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ ignored_warnings_from = ['lib', 'test', 'contracts/test']
verbosity = 4
# disable metadata for bytecode comparison
cbor_metadata = false
bytecode_hash = "none"

[rpc_endpoints]
mainnet = "${RPC_URL_MAINNET}"
Expand Down
Loading