refactor: move @hyperlane-xyz/utils to devDependencies in core#7805
refactor: move @hyperlane-xyz/utils to devDependencies in core#7805
Conversation
Utils is only used in test files (addressToBytes32, messageId, parseMessage), not in the published Solidity contracts or build artifacts. Note: Previously, utils changes implied transitive patch bumps to core, which could affect onchain bytecode versioning. This change breaks that dependency chain, requiring explicit changesets for core when contracts change.
|
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on February 13. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
|
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Claude finished @yorhodes's task in 1m 7s —— View job Review Complete
SummaryThis PR correctly moves VerificationI verified that
The utils are used for test helpers (
Security ReviewNo security concerns. This is a purely build-related change that:
The change correctly breaks the transitive dependency chain, preventing unnecessary version bumps to CI StatusThe This is an infrastructure issue that should resolve on retry. RecommendationApprove. The change is correct and aligns with best practices for dependency management. |
🐳 Monorepo Docker Image Built SuccessfullyImage Tags: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7805 +/- ##
=======================================
Coverage 77.02% 77.02%
=======================================
Files 117 117
Lines 2651 2651
Branches 244 244
=======================================
Hits 2042 2042
Misses 593 593
Partials 16 16
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Summary
@hyperlane-xyz/utilsfromdependenciestodevDependenciesin@hyperlane-xyz/coreaddressToBytes32,messageId,parseMessage), not in published contracts or build artifactsContext
Previously, changes to
@hyperlane-xyz/utilsimplied transitive patch bumps to@hyperlane-xyz/core, which could affect onchain bytecode versioning even when no contracts changed. This change breaks that dependency chain.With the new Solidity changeset validation CI (#7801), explicit changesets are now required for
@hyperlane-xyz/corewhen contracts change, making this transitive bump unnecessary.