refactor(infra): remove kathy and tidy monorepo docker workflow#7893
refactor(infra): remove kathy and tidy monorepo docker workflow#7893paulbalaji merged 7 commits intomainfrom
Conversation
ce02f85 to
b22b03b
Compare
b22b03b to
47a3e31
Compare
491ee77 to
45ed7c4
Compare
47a3e31 to
f31af2e
Compare
45ed7c4 to
1de7f87
Compare
f31af2e to
d10289c
Compare
8408efc to
5f12aae
Compare
d10289c to
5874d63
Compare
5f12aae to
f65320b
Compare
a4da1a1 to
43dbfcd
Compare
f65320b to
992f37b
Compare
455037a to
e3c1e15
Compare
542cd49 to
6d88f89
Compare
e3c1e15 to
9d49a21
Compare
|
will deal with conflicts once #7721 is merged |
085649d to
29862e4
Compare
📝 WalkthroughWalkthroughThis PR removes the Kathy agent and HelloWorld subsystem: deletes Kathy role, configs, Helm chart, deployment scripts, HelloWorld types/utilities, JSON data, adjusts funding/role logic, and narrows the monorepo Docker workflow triggers and steps. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @.github/workflows/monorepo-docker.yml:
- Around line 9-15: The workflow's PR path filter omits build-input files so
changes to .registryrc and solidity/.foundryrc won't trigger the Docker build;
update the paths list in the monorepo-docker.yml workflow by adding
'.registryrc' and 'solidity/.foundryrc' alongside the existing entries (e.g.,
the list that currently contains 'Dockerfile', 'docker-entrypoint.sh',
'.dockerignore', '.github/workflows/monorepo-docker.yml', 'pnpm-lock.yaml') so
PRs touching those files will run the workflow.
🧹 Nitpick comments (2)
typescript/infra/src/agents/key-utils.ts (1)
503-503: Type the relayer variable to avoid implicitany.
let relayer;falls back toany, which dodges type safety. A simple annotation keeps it honest and matches the rest of the infra typing discipline.♻️ Suggested tweak
- let relayer; + let relayer: Address | undefined;.github/workflows/monorepo-docker.yml (1)
76-78: Pin Depot action to a commit SHA for supply-chain safety.Using a floating tag like
@v1can drift. Pinning to a specific commit keeps builds deterministic and safer.🔐 Safer pinning pattern
- - name: Set up Depot CLI - uses: depot/setup-action@v1 + - name: Set up Depot CLI + uses: depot/setup-action@<COMMIT_SHA>
bcd5793 to
b73ca41
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@typescript/infra/src/agents/key-utils.ts`:
- Around line 502-505: The variable relayer is declared without a type causing a
noImplicitAny error; update its declaration to include an explicit type (for
example: let relayer: Relayer | undefined; or if a concrete Relayer type doesn't
exist yet use let relayer: unknown | undefined and narrow it later) so the
compiler knows its type when used in the loop that iterates over keys; ensure
you import or define the Relayer type if you choose the former and adjust
subsequent code to handle the possibly undefined value.
… workflow - Remove PR commenting from monorepo-docker workflow, add job summary instead - Reduce PR triggers to only essential paths (Dockerfile, pnpm-lock.yaml, workflow file) - Delete helm/helloworld-kathy/ helm chart (k8s deployment dead) - Delete KathyHelmManager and deploy-kathy script - Remove kathy docker tags from docker.ts - Remove docker config from helloworld kathy configs (keep e2e test config) - Remove KathyHelmManager usage from rpcUrls.ts Kathy k8s deployment infrastructure is no longer used. Only e2e test code remains. checkWarpDeploy is now the only k8s user of the monorepo image.
- Remove PR commenting step from monorepo-docker workflow (job summary only) - Add key-funder and ts-relayer to docker-image-comment emoji mapping Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Remove helloworld/kathy production service infrastructure that was previously deployed to k8s. Rust e2e tests continue to work via `pnpm kathy` which runs send-test-messages.ts (not the removed production kathy.ts). Removed: - scripts/helloworld/ - production kathy service - config/environments/*/helloworld.ts - helloworld configs - config/environments/*/helloworld/ - verification JSONs - config/kathy.json - kathy wallet addresses - src/config/helloworld/types.ts - HelloWorldConfig types - Role.Kathy and related funding configs - HelloWorld deployer and checker from deploy/check scripts - @hyperlane-xyz/helloworld dependency from infra Kept: - scripts/send-test-messages.ts - used by Rust e2e via `pnpm kathy` Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
ea828ed to
7d2f9b9
Compare
⚙️ Node Service Docker Images Built Successfully
Full image paths |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7893 +/- ##
=======================================
Coverage 77.02% 77.02%
=======================================
Files 117 117
Lines 2651 2651
Branches 244 244
=======================================
Hits 2042 2042
Misses 593 593
Partials 16 16
🚀 New features to boost your workflow:
|
Summary
Removes Kathy k8s deployment infrastructure and the helloworld production service. Tidies up the monorepo Docker workflow.
Changes
Monorepo Docker Workflow
pull-requests: writepermissionKathy K8s Removal
helm/helloworld-kathy/helm chartKathyHelmManagerclass anddeploy-kathy.tsscriptdocker.tsHelloworld Production Service Removal
scripts/helloworld/kathy.tsandutils.tsconfig/environments/*/helloworld.tsconfigsconfig/environments/*/helloworld/address/verification JSONsconfig/kathy.jsonaddressessrc/config/helloworld/types.tsRole.Kathyand kathy funding configs@hyperlane-xyz/helloworlddependency from infraModules.HELLO_WORLDfrom agent-utilsWhat's Kept (Rust E2E)
scripts/send-test-messages.ts- Rust e2e uses this viapnpm kathyContext
Kathy was a production service that sent test messages between chains. It was deployed to k8s but is no longer used. The Rust e2e tests use a separate script (
send-test-messages.ts) that doesn't depend on any of the removed helloworld infrastructure.checkWarpDeploy is now the only remaining user of the monorepo Docker image in k8s deployments.
Test plan
pnpm -C typescript/infra buildpassespnpm kathy(uses send-test-messages.ts)Stacked on: #7721
Summary by CodeRabbit
Removals
Chores
✏️ Tip: You can customize this high-level summary in your review settings.