fix(solidity): fix tron-sdk build failures from soldeer panic and partial typechain cache#8205
fix(solidity): fix tron-sdk build failures from soldeer panic and partial typechain cache#8205
Conversation
…ttribution `forge soldeer install --quiet` panics in forge v1.1.0 due to a logger double-init bug, breaking both `deps:soldeer` and `build-tron.sh`. Since turbo guarantees dependencies are already installed via task ordering (build:tron → build → deps:soldeer), the call can safely fall through. Also fix lint-staged oxfmt rule for JSON files (same issue as #8085) and disable Co-Authored-By commit attribution for Claude Code.
Hardhat/typechain can emit partial type trees when incremental cache is reused against cleaned output dirs. Wipe cache-tron, abi, and typechain dirs at the start of build-tron.sh to ensure deterministic outputs.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR adds a top-level Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
cache-tron,abi,typechain) before compilation to prevent hardhat/typechain from emitting partial type trees when incremental cache is reused against cleaned output dirsforge soldeer install --quietnon-fatal inbuild-tron.shanddeps:soldeer— works around a forge v1.1.0SetLoggerErrorpanic where the logger is initialized twiceoxfmtrule for*.jsonfiles — add--no-error-on-unmatched-pattern(same fix as fix: add --no-error-on-unmatched-pattern to oxfmt md rule in lint-staged #8085 for*.md)Co-Authored-Bycommit attribution in project settingsContext
pnpm buildfails on a clean checkout because:forge soldeer install --quietpanics in forge v1.1.0, failing bothdeps:soldeerandbuild-tron.shbuild:tron, the cached output can contain partial typechain trees (238 index files but only 4 actual type files), causingtscintron-sdkto fail with missing module errorsThe soldeer call in
build-tron.shis redundant when running through turbo since task ordering guarantees deps are installed (build:tron→build→deps:soldeer). Making it non-fatal keeps standalone invocations working while unblocking the turbo pipeline.Subsumes #8204.
Test plan
pnpm install && pnpm buildsucceeds (25/25 tasks pass) with forge v1.1.0Summary by CodeRabbit
Documentation
Chores
Tests / CI