fix: remove unused bin entries from rebalancer and relayer packages#8264
Closed
paulbalaji wants to merge 1 commit intomainfrom
Closed
fix: remove unused bin entries from rebalancer and relayer packages#8264paulbalaji wants to merge 1 commit intomainfrom
paulbalaji wants to merge 1 commit intomainfrom
Conversation
These bin fields were cargo-culted from the CLI package when rebalancer and relayer were extracted into standalone packages. Unlike the CLI, these are services (not CLI tools) and are never invoked via npx or global install — they run via node dist/service.js or Docker CMD. The dangling bin entries cause pnpm to warn on every fresh install because the dist/ targets don't exist pre-build, producing noise like: WARN Failed to create bin at .../node_modules/.bin/hyperlane-rebalancer. ENOENT: no such file or directory, open '.../dist/service.js'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
binfields from@hyperlane-xyz/rebalancerand@hyperlane-xyz/relayerpackage.json filesInvestigation
These
binentries were causing pnpm warnings on every fresh install in CI:Root cause: The
binfields were cargo-culted from the CLI package when rebalancer (#7544) and relayer (#7671) were extracted into standalone packages. Unlike the CLI (which is a user-installed command-line tool), these are services — they run vianode dist/service.jsor DockerCMD ["node", "bundle/index.js"], never vianpxor global install.Why pnpm warns: During
pnpm install, pnpm tries to create symlinks innode_modules/.bin/of every dependent package (cli, infra, rebalancer-sim). The targets (dist/service.js,dist/fs/service.js) don't exist pre-build, so every symlink creation fails with ENOENT.Why removal is safe:
Dockerfile.node-serviceusesCMD ["node", "bundle/index.js"], rootDockerfilehas no CMDhyperlane-rebalancerorhyperlane-relayeras commandsbinfieldbinin the monorepo istypescript/cli("hyperlane": "./bundle/index.js"), which is correctTest plan
🤖 Generated with Claude Code
Note
Cursor Bugbot is generating a summary for commit 44e4edb. Configure here.