fix: use Hyper Gonk identity for git commits#1258
Conversation
|
📝 WalkthroughWalkthroughWorkflows and an internal action were changed so Git author identity is no longer hardcoded: workflows generate and set git user.name and user.email from the GitHub App token app-slug and HYPER_GONK_APP_ID, while the commit-changes action no longer configures global git identity. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🔇 Additional comments (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The previous fix used Hyper Gonk token for authentication but still used github-actions[bot] for git commit identity. This caused commits to still show as github-actions bot. Changes: - update-hyperlane-deps.yml: Use app-slug output for git config - release.yml: Add setupGitUser: false to changesets action and configure git identity manually - combine.yml: Configure git identity before commit-changes action - commit-changes action: Remove hardcoded git config (now expects caller to configure git identity) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
942aff2 to
0e70352
Compare
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Claude <noreply@anthropic.com>
Summary
The previous fix (PR #1256) used Hyper Gonk token for authentication but still used
github-actions[bot]for git commit identity. This caused commits to still show as github-actions bot.Changes
update-hyperlane-deps.ymlUses the
app-slugoutput fromcreate-github-app-tokento configure git identity.release.ymlsetupGitUser: falseto the changesets actioncombine.ymlAdded git config step before
commit-changesaction calls.commit-changesactionRemoved hardcoded
github-actions[bot]git config. The calling workflow is now responsible for configuring git identity.The git identity format:
user.name:\${{ steps.generate-token.outputs.app-slug }}[bot]user.email:\${{ secrets.HYPER_GONK_APP_ID }}+\${{ steps.generate-token.outputs.app-slug }}[bot]@users.noreply.github.comRelated
🤖 Generated with Claude Code
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.