Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add WeaveVM #378

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add WeaveVM #378

wants to merge 1 commit into from

Conversation

charmful0x
Copy link

Description

Add WeaveVM Testnet

Backward compatibility

Yes

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 12, 2024

⚠️ No Changeset found

Latest commit: c6e5c16

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@JunayedMh
Copy link
Contributor

add logo.svg and changeset file

paulbalaji
paulbalaji reviewed Nov 27, 2024
View reviewed changes
Copy link
Contributor

@paulbalaji paulbalaji left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. rename weavevm -> weavevmtestnet
  2. add a logo.svg
  3. run yarn changeset add to add a changeset

chains/weavevm/metadata.yaml
confirmations: 1
estimateBlockTime: 1
reorgPeriod: 1
chainId: 9496
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add your deployer details e.g.

hyperlane-registry/chains/abstracttestnet/metadata.yaml

Lines 12 to 14 in b044eca

deployer:
name: Abacus Works
url: https://www.hyperlane.xyz

chains/weavevm/metadata.yaml
Comment on lines +23 to +25
transactionOverrides:
maxFeePerGas: 1000000000
maxPriorityFeePerGas: 1000000000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this necessary? any docs recommending this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalaji paulbalaji paulbalaji left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@charmful0x @JunayedMh @paulbalaji