-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: validate chains and warp routes, change jobs to run on main #457
Conversation
🦋 Changeset detectedLatest commit: 17c527b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
You need to add a changeset otherwise it won't pass the git checks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very glad to have this new coverage but I think we should shuffle things around a bit (see comments)
) ### Description <!-- Summary of change. Example: Add sepolia chain --> Fixes #439 and #209 - Change `combine` and `optimize-svg` jobs to only run when commited to `main` - Add script to validate chains and warp routes - Add `step` in `ci.ym`l test job to run these - For chains it will check for missing `deployer` field and if its missing logo file - For warp routes it will check for missing config file and if chain names are ordered correctly - Updated `chain` test to check if `isTestnet` is set properly - Update `warp-routes` test to check for `logoURI` field ### Backward compatibility <!-- Are these changes backward compatible? Note that additions are backwards compatible. Yes/No --> Yes ### Testing Manual
) ### Description <!-- Summary of change. Example: Add sepolia chain --> Fixes #439 and #209 - Change `combine` and `optimize-svg` jobs to only run when commited to `main` - Add script to validate chains and warp routes - Add `step` in `ci.ym`l test job to run these - For chains it will check for missing `deployer` field and if its missing logo file - For warp routes it will check for missing config file and if chain names are ordered correctly - Updated `chain` test to check if `isTestnet` is set properly - Update `warp-routes` test to check for `logoURI` field ### Backward compatibility <!-- Are these changes backward compatible? Note that additions are backwards compatible. Yes/No --> Yes ### Testing Manual
Description
Fixes #439 and #209
combine
andoptimize-svg
jobs to only run when commited tomain
step
inci.ym
l test job to run thesedeployer
field and if its missing logo filechain
test to check ifisTestnet
is set properlywarp-routes
test to check forlogoURI
fieldBackward compatibility
Yes
Testing
Manual