Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: validate chains and warp routes, change jobs to run on main #457

Merged
merged 9 commits into from
Jan 6, 2025

Conversation

Xaroz
Copy link
Contributor

@Xaroz Xaroz commented Jan 2, 2025

Description

Fixes #439 and #209

  • Change combine and optimize-svg jobs to only run when commited to main
  • Add script to validate chains and warp routes
  • Add step in ci.yml test job to run these
  • For chains it will check for missing deployer field and if its missing logo file
  • For warp routes it will check for missing config file and if chain names are ordered correctly
  • Updated chain test to check if isTestnet is set properly
  • Update warp-routes test to check for logoURI field

Backward compatibility

Yes

Testing

Manual

@Xaroz Xaroz self-assigned this Jan 2, 2025
Copy link

changeset-bot bot commented Jan 2, 2025

🦋 Changeset detected

Latest commit: 17c527b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hyperlane-xyz/registry Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@JaunePomme
Copy link
Contributor

You need to add a changeset otherwise it won't pass the git checks

Copy link
Collaborator

@jmrossy jmrossy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very glad to have this new coverage but I think we should shuffle things around a bit (see comments)

scripts/validate-file-data.js Outdated Show resolved Hide resolved
scripts/validate-file-data.js Outdated Show resolved Hide resolved
scripts/validate-file-data.js Outdated Show resolved Hide resolved
scripts/validate-file-data.js Outdated Show resolved Hide resolved
scripts/validate-file-data.js Outdated Show resolved Hide resolved
scripts/validate-file-data.js Show resolved Hide resolved
scripts/validate-file-data.js Outdated Show resolved Hide resolved
@Xaroz Xaroz requested a review from jmrossy January 4, 2025 00:13
scripts/validate-file-data.js Show resolved Hide resolved
@Xaroz Xaroz added this pull request to the merge queue Jan 6, 2025
Merged via the queue into main with commit 23186f9 Jan 6, 2025
6 checks passed
@Xaroz Xaroz deleted the chore/validate-yaml branch January 6, 2025 18:35
ltyu pushed a commit that referenced this pull request Jan 7, 2025
)

### Description

<!--
Summary of change.
Example: Add sepolia chain
-->

Fixes #439 and #209 

- Change `combine` and `optimize-svg` jobs to only run when commited to
`main`
- Add script to validate chains and warp routes
- Add `step` in `ci.ym`l test job to run these
- For chains it will check for missing `deployer` field and if its
missing logo file
- For warp routes it will check for missing config file and if chain
names are ordered correctly
- Updated `chain` test to check if `isTestnet` is set properly
- Update `warp-routes` test to check for `logoURI` field

### Backward compatibility

<!--
Are these changes backward compatible? Note that additions are backwards
compatible.

Yes/No
-->

Yes

### Testing

Manual
ltyu pushed a commit that referenced this pull request Jan 8, 2025
)

### Description

<!--
Summary of change.
Example: Add sepolia chain
-->

Fixes #439 and #209 

- Change `combine` and `optimize-svg` jobs to only run when commited to
`main`
- Add script to validate chains and warp routes
- Add `step` in `ci.ym`l test job to run these
- For chains it will check for missing `deployer` field and if its
missing logo file
- For warp routes it will check for missing config file and if chain
names are ordered correctly
- Updated `chain` test to check if `isTestnet` is set properly
- Update `warp-routes` test to check for `logoURI` field

### Backward compatibility

<!--
Are these changes backward compatible? Note that additions are backwards
compatible.

Yes/No
-->

Yes

### Testing

Manual
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve registry review process with more checks
4 participants